Conversation
xosk31
approved these changes
Sep 22, 2026
xosk31
left a comment
Collaborator
There was a problem hiding this comment.
Thank you very much for your contribution
kenichi-mashiyama
deleted the
add-h1-case-adjust-bogus-server-option
branch
September 22, 2026 12:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for configuring the
h1-case-adjust-bogus-serveroption within thedefaultssection of HAProxy configurations.Motivation
By default, HAProxy normalizes HTTP header names to lowercase. While this complies with standard HTTP specifications, some legacy or non-compliant backend servers ("bogus servers") fail to process HTTP headers correctly if they are not in a specific case (e.g., CamelCase). The
h1-case-adjust-bogus-serveroption in HAProxy provides a workaround for this issue. By introducing theh1CaseAdjustBogusServerfield to theDefaultsConfigurationstruct, users can now enable this option globally across all proxies directly via the Instance CRD.Changes
H1CaseAdjustBogusServer(bool) field to theDefaultsConfigurationstruct inapis/proxy/v1alpha1/instance_types.go.Model()method inapis/proxy/v1alpha1/instance_types.goto map this new field to the native HAProxy model (defaults.H1CaseAdjustBogusServer = models.DefaultsBaseH1CaseAdjustBogusServerEnabled).TestDefaultsConfiguration_AddToParser_H1CaseAdjustBogusServerEnabledandTestDefaultsConfiguration_AddToParser_H1CaseAdjustBogusServerDisabledByDefault) inapis/proxy/v1alpha1/instance_types_test.goto verify the correct generation of theoption h1-case-adjust-bogus-serverconfiguration line.h1CaseAdjustBogusServerfield.Checklist