Add log options - #238
Open
kenichi-mashiyama wants to merge 1 commit into
Open
Add log options#238kenichi-mashiyama wants to merge 1 commit into
kenichi-mashiyama wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for configuring various logging options in the
defaultssection, as well as specific logging options forbackends.Motivation
Currently, the HAProxy Operator lacks granular control over certain native HAProxy logging behaviors directly through the CRDs. Users often need to enable separate error logging, suppress null connection logs, format HTTP logs in CLF, or log health checks. By introducing
DefaultsOptions(for Instance CRD) andBackendOptions(for Backend CRD), users can now explicitly configure standard HAProxy logging options (such asoption log-separate-errors,option httplog clf,option dontlognull, andoption dontlog-normal) dynamically through the Operator.Changes
BackendOptionsstruct with theLogHealthChecksfield toBackendSpecinapis/config/v1alpha1/backend_types.go.DefaultsOptionsstruct withLogSeparateErrors,LogHealthChecks,Dontlognull,DontlogNormal, andHTTPLogCLFfields toDefaultsConfigurationinapis/proxy/v1alpha1/instance_types.go.Model()andAddToParser()methods to map these new fields to the native HAProxy configuration lines.backend_types_test.goandinstance_types_test.goto verify the correct parsing and generation of these options.Checklist