Repository navigation
[compass] Remove dead code: the unused default on the CLI's validating Connect overload - #93
Merged
Merged
Conversation
…g Connect overload
Every one of its 15 callers passes the request's arguments, so the `= null` default
was never used. Without it, a caller must hand over the payload it sends, which is
what the method's summary promises ("using the envelope RequestAsync sends").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line: the
= nulldefault on the CLI's validatingConnect(string op, JsonObject? arguments)overload (src/Anode/Cli/AgentCommands.cs:37, added by #82 for B-053) is never used.What was removed, and why it is dead
arguments = null. All 15 callers pass the request's payload as the second argument:AndroidCommands.cs:89,:120Cli.cs:205,:521,:544,:568,:595,:607,:617,:625,:644,:660,:713DevelopmentCommands.cs:62DisplayCommands.cs:27Connect("input.scroll"), and the build failed with CS1503: overload resolution falls toConnect(bool autoStart). So no call can rely on the default, and no existing call binds differently. The control was then reverted.private staticinside the exe.How the rest of #79..main was scanned (82131b1..b661f63: 12 commits, 13 source files)
tools/anode-scan.sh, steps 1–10 (82 s). Each step's planted control fired.catchblocks inScreenSettle.cs. They are deliberate (capture failures must never fail a sent scroll), and a style matter rather than dead code.ConnectForCheck's setter, which is a test hook.Connect(autoStart: false)callers send status or viewer ops that need no lease, or validate their own envelope first (audio).ScreenSettle.Around'stimeoutMsdefault is used by a check.ScreenRecorderstand-in members are read.Around's firstif (Cancel.IsCancellationRequested)branch.ThrowIfCancellationRequested()always throws on that path.Tests
b661f63scripts\build.ps1 -QuickTest -OutputDirectory artifacts\pkg-build(release build plusselftest --quick)Risk
1ad6eae(LEDGER C-072), so it doesn't move.Second review
bin/codex-review.shstopped after 6 s at the Codex usage limit ("try again at Nov 4th, 2026 9:30 AM"). The transcript islogs/codex/2026-10-30-0312-2026-10-30-dead-code-anode.out.txtin Compass.#if.nameof, method group or reflection, and the project has no source generators.ConnectForCheckhooksConnect(bool), not this overload, and overload resolution can't shift.privatein the only project, with noInternalsVisibleTo.Merged by compass-dead-code in this run once its tests and second review pass (RULES.md, Pull requests).
🤖 Generated with Claude Code