tpd: a Root that repeats the last tree is a no-change - #5269
Merged
Merged
Conversation
A visor republishes its Root every 45 s even when nothing changed; the objects are content-addressed, so on the wire that heartbeat is only the small signed Root. TPD applied every one as new — every telemetry shard and the whole transport list, for every visor, every 45 s. A Root whose tree hash matches the reporter's last Root applied in full is skipped, except once per 90 s, which keeps registrations (5-minute TTL) and uptime heartbeats (90 s cadence) alive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A visor republishes its Root every 45 s even when nothing changed; objects are content-addressed, so on the wire that heartbeat is just the small signed Root. TPD applied every one as new — every telemetry shard and the whole transport list, for every visor, every 45 s.
A Root whose tree hash matches the reporter's last Root applied in full is skipped, except once per 90 s, which keeps registrations (5-minute TTL) and uptime heartbeats (90 s cadence) alive.