Repository navigation
tpd: apply each transport edge's telemetry at most every 2 minutes - #5275
Merged
Merged
Conversation
Keepalive pings move every live transport's byte counters, so the unchanged-shard dedup cannot skip them: both edges of ~80k transports reported every 45 s, ~3k bandwidth and ~1.5k latency scripts a second (~20 redis commands each) on prod01 after skycoin#5274 removed the metrics reads — now the bulk of TPD's load. Counters are cumulative, so applying fewer snapshots loses no bytes; the next delta spans the skipped ones. Latency is kept as the latest and throughput as the peak over held reports. A held snapshot is flushed when its window passes, and the first report of a UTC day applies at once. Uptime heartbeats are paced separately, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keepalive pings move every live transport's byte counters, so the unchanged-shard dedup (#5268) cannot skip them: both edges of ~80k transports reported every 45 s — ~3k bandwidth and ~1.5k latency scripts a second, ~20 redis commands each, measured on prod01 after #5274 removed the metrics reads. That is now the bulk of TPD's load.
Counters are cumulative, so applying fewer snapshots loses no bytes; the next delta spans the skipped ones. Latency is kept as the latest and throughput as the peak over held reports. A held snapshot is flushed once its window passes (a transport that goes away keeps its last delta), and the first report of a UTC day applies at once. Uptime heartbeats are paced separately, as before.