Fix slide bar bounds and bitmap palette color issues - #200
Merged
Merged
Conversation
The returned value of getBoundaryX is used as the left position of the selector, but it was clamped by the half size of the selector. So the selector was placed over the right edge when the position is the maximum. Fixes #116
A pixel of a bitmap palette has its own brightness and alpha, but the slide bars kept their own positions and overrode them. So picking a dark pixel notified a bright color, and picking black notified white. Fixes #92
getHexCode returns the AARRGGBB form, which is not documented anywhere. getRgbHexCode returns the RRGGBB form for the cases the alpha channel is not needed. Fixes #123
AlphaTileView crashed with IllegalArgumentException when its size was changed to zero. Also updates the ABI dump file.
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the slide bar selector inside the bounds at the maximum position (#116).
Syncs the alpha and brightness slide bars with a pixel picked from a bitmap palette, so a dark pixel is not notified as a bright color (#92).
Adds ColorEnvelope.getRgbHexCode and documents that getHexCode is the AARRGGBB form (#123).
Guards AlphaTileView against creating a zero sized bitmap.