Skip to content

This is a bad idea... #21

Description

@pidupuis

What I'm going to say is my opinion and only mine.

This is a bad idea...

  • You lost readability of your commits in environments where emojis are not readable, which represents a lot of environments!
  • Readers must learn the meaning of an emoji instead of just reading a more-efficient keyword.

... full of bad ideas

  • Not only you have to learn the meaning of the emojis, but it changes depending on the tools !
🐘 	:elephant: 	PostgreSQL Database specific (Migrations, Scripts, Extensions, ...)
🐬 	:dolphin: 	MySQL Database specific (Migrations, Scripts, Extensions, ...)
🍃 	:leaves: 	MongoDB Database specific (Migrations, Scripts, Extensions, ...)
🏦 	:bank: 	        Generic Database specific (Migrations, Scripts, Extensions, ...)
🐳 	:whale: 	Docker Configuration
  • If it is not enough, you encourage users to extend the lists!
  • You force to add at least one emoji, which means that you think about putting plenty of them, which takes a lot of place if not translated!
:emoji1: :emoji2: Subject
  • There are some contradictions in your guide:
    All WIP(Work In Progress) Commits MUST have the WIP Emoji(see below).
    ...
    All WIP Commits Should be Avoided!.
  • While the WIP commit is obviously a residual mistake, I should mention that you authorize to commit bugs!!
🐛 	:bug: 	when reporting a bug, with @FIXMEComment Tag

I thus think one should not follow this guideline, or at least not in its current state.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions