fix(web): stop health checks restarting healthy relays - #432
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEB health checks restarted healthy relays when
[web].listenselected a non-loopback address or the public root returned its intended 404 withoutpublic_dir. Read both listener aliases in configuration order, accept completed local HTTP responses, and allow public HTTPS 404 while continuing to report other 4xx/5xx and transport/TLS failures without restarting the relay.Add executable shell regression coverage with real curl HTTP fixtures and stubbed systemd, wire it into CI, and document the follow-up
sudo mtbuddy update --forcerequired to replace embedded health scripts after upgrading an older updater.Validation: 495 Zig tests passed in Linux with Zig 0.16.0; all 20 Python regression tests passed; Linux x86_64_v3+aes release cross-build and formatting passed. The new tests reproduced the original failures before the fix. Independent review found no blockers.
Fixes #431.