Skip to content

fix: Bump GAF to gate metacharacter ignore fix behind flag - #7039

Closed
danskmt wants to merge 1 commit into
mainfrom
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
Closed

fix: Bump GAF to gate metacharacter ignore fix behind flag#7039
danskmt wants to merge 1 commit into
mainfrom
fix/CLI-1709-bump-gaf-metacharacter-fix-flag

Conversation

@danskmt

@danskmt danskmt commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages are release-note ready, emphasizing what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Bumps go-application-framework and code-client-go to versions where the ignore-rule/path regex-metacharacter fix is opt-in, gated behind configuration.FF_FILE_FILTER_METACHARACTER_FIX, instead of always on. No code changes in this repo itself — the flag is read and applied inside code-client-go.

Where should the reviewer start?

How should this be manually tested?

  1. Run the CLI test suite (make test in cliv2) and confirm it passes with the bumped dependencies.
  2. Scan a directory containing a path or ignore rule with regex metacharacters (e.g. a folder named build (old)) and confirm exclusion behavior matches legacy behavior by default.

What's the product update that needs to be communicated to CLI users?

Introduces snykFileFilterMetacharacterFix feature flag capability, but no impact at the moment, because we are preserving the current behavior that is in Preview CLI until we can release all the .gitignore related changes in other repos as well (e.g. code-client-go, etc..) as they need to plug the config to the new constructor so they can make use of it.

@snyk-io

snyk-io Bot commented Jul 27, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from 0ef35e2 to c66ca92 Compare July 28, 2026 11:16
@danskmt
danskmt marked this pull request as ready for review July 28, 2026 12:28
@danskmt
danskmt requested a review from a team as a code owner July 28, 2026 12:28
@snyk-pr-review-bot

This comment has been minimized.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from c66ca92 to 0ab81a2 Compare July 29, 2026 11:26
@snyk-pr-review-bot

This comment has been minimized.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from 0ab81a2 to 0aa98c4 Compare July 29, 2026 11:44
@snyk-pr-review-bot

This comment has been minimized.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from 0aa98c4 to c110d58 Compare July 29, 2026 12:09
@snyk-pr-review-bot

This comment has been minimized.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from c110d58 to 8d9d33d Compare July 29, 2026 13:15
@snyk-pr-review-bot

This comment has been minimized.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from 8d9d33d to c1e3a9b Compare July 29, 2026 13:26
@snyk-pr-review-bot

This comment has been minimized.

@danskmt
danskmt force-pushed the fix/CLI-1709-bump-gaf-metacharacter-fix-flag branch from c1e3a9b to 7897f2b Compare July 29, 2026 14:05
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Incomplete Dependency Update 🟠 [major]

The PR description explicitly states that it 'Bumps go-application-framework and code-client-go', but the changes in cliv2/go.mod only include the go-application-framework bump. github.com/snyk/code-client-go remains at v1.27.0 (line 22) in the public module, whereas the private module (cliv2-private/go.mod) already references v1.27.5 (line 218). This discrepancy suggests that the public CLI will not receive the intended opt-in logic for the regex metacharacter fix, as that logic resides within the code-client-go extension which was not updated for the public build.

github.com/snyk/go-application-framework v0.8.1
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 3 files (average relevance: 0.97)

🤖 Repository instructions applied (from AGENTS.md)

@danskmt danskmt closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant