fix: Bump GAF to gate metacharacter ignore fix behind flag - #7039
Closed
danskmt wants to merge 1 commit into
Closed
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 28, 2026 11:16
0ef35e2 to
c66ca92
Compare
Merged
4 tasks
danskmt
marked this pull request as ready for review
July 28, 2026 12:28
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 29, 2026 11:26
c66ca92 to
0ab81a2
Compare
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 29, 2026 11:44
0ab81a2 to
0aa98c4
Compare
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 29, 2026 12:09
0aa98c4 to
c110d58
Compare
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 29, 2026 13:15
c110d58 to
8d9d33d
Compare
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 29, 2026 13:26
8d9d33d to
c1e3a9b
Compare
This comment has been minimized.
This comment has been minimized.
danskmt
force-pushed
the
fix/CLI-1709-bump-gaf-metacharacter-fix-flag
branch
from
July 29, 2026 14:05
c1e3a9b to
7897f2b
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Bumps
go-application-frameworkandcode-client-goto versions where the ignore-rule/path regex-metacharacter fix is opt-in, gated behindconfiguration.FF_FILE_FILTER_METACHARACTER_FIX, instead of always on. No code changes in this repo itself — the flag is read and applied insidecode-client-go.Where should the reviewer start?
cliv2/go.mod/cliv2/go.sum– GAF + code-client-go version bumpcliv2-private/go.mod/cliv2-private/go.sum– indirect dependency bumpHow should this be manually tested?
make testincliv2) and confirm it passes with the bumped dependencies.build (old)) and confirm exclusion behavior matches legacy behavior by default.What's the product update that needs to be communicated to CLI users?
Introduces snykFileFilterMetacharacterFix feature flag capability, but no impact at the moment, because we are preserving the current behavior that is in Preview CLI until we can release all the .gitignore related changes in other repos as well (e.g. code-client-go, etc..) as they need to plug the config to the new constructor so they can make use of it.