Skip to content

fix: add user journey tests for FUA code path + bump code-client-go - #7064

Merged
florinMiro merged 1 commit into
mainfrom
fix/bundle_deduplication_observability_and_add_fua_code_test
Jul 31, 2026
Merged

fix: add user journey tests for FUA code path + bump code-client-go#7064
florinMiro merged 1 commit into
mainfrom
fix/bundle_deduplication_observability_and_add_fua_code_test

Conversation

@florinMiro

@florinMiro florinMiro commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Risk assessment (Low | Medium | High)?

Low

@snyk-io

snyk-io Bot commented Jul 31, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@florinMiro
florinMiro force-pushed the fix/bundle_deduplication_observability_and_add_fua_code_test branch from cacc217 to 388ecb5 Compare July 31, 2026 10:22
@florinMiro
florinMiro marked this pull request as ready for review July 31, 2026 12:07
@florinMiro
florinMiro requested a review from a team as a code owner July 31, 2026 12:07
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

ReferenceError in Helper 🔴 [critical]

The newly added readJson function calls readFileSync(filePath, 'utf8') without the fs. prefix. Since readFileSync was not explicitly imported from fs-extra or fs (only * as fs was imported), this will result in a ReferenceError: readFileSync is not defined when the tests run.

const readJson = (filePath: string): any =>
  JSON.parse(readFileSync(filePath, 'utf8'));
📚 Repository Context Analyzed

This review considered 5 relevant code sections from 4 files (average relevance: 1.00)

🤖 Repository instructions applied (from AGENTS.md)

@florinMiro florinMiro changed the title chore: add user journey tests for FUA code path fix: add user journey tests for FUA code path + bump code-client-go Jul 31, 2026
@florinMiro

Copy link
Copy Markdown
Contributor Author

ReferenceError in Helper 🔴 [critical]
The newly added readJson function calls readFileSync(filePath, 'utf8') without the fs. prefix. Since readFileSync was not explicitly imported from fs-extra or fs (only * as fs was imported), this will result in a ReferenceError: readFileSync is not defined when the tests run.

This is a hallucination, importing readFileSync from fs.
import { existsSync, unlinkSync, readFileSync } from 'fs';

@florinMiro
florinMiro merged commit 186a75f into main Jul 31, 2026
13 of 14 checks passed
@florinMiro
florinMiro deleted the fix/bundle_deduplication_observability_and_add_fua_code_test branch July 31, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants