chore: bump GAF to enable GitIgnore Feature Flags - #7065
Open
octavian-snyk wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
4 tasks
danskmt
reviewed
Jul 31, 2026
Comment on lines
49
to
53
| if config.GetBool(configuration.PREVIEW_FEATURES_ENABLED) { | ||
| config.Set("INTERNAL_USE_UFM_PRESENTER", true) | ||
| config.Set(utils.FF_FILE_FILTER_METACHARACTER_FIX, true) | ||
| config.Set(utils.FF_GITIGNORE_RESPECT_TRACKED_FILES, true) | ||
| } |
Contributor
There was a problem hiding this comment.
this is the current workaround that can be removed once CLI-1733 is solved, right? @octavian-snyk
Contributor
There was a problem hiding this comment.
I think worth adding a comment here?
octavian-snyk
force-pushed
the
chore/bump_gaf
branch
4 times, most recently
from
July 31, 2026 14:31
f6b2b3d to
6faa54f
Compare
octavian-snyk
marked this pull request as ready for review
July 31, 2026 14:32
octavian-snyk
force-pushed
the
chore/bump_gaf
branch
from
July 31, 2026 14:32
6faa54f to
7d6d07f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
octavian-snyk
force-pushed
the
chore/bump_gaf
branch
from
July 31, 2026 14:40
7d6d07f to
9602437
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR bumps CLI's GAF version, which makes .gitignore / file-filter behavior configuration-driven instead.
GAF registers two lazy-loaded remote feature flags:
FF_FILE_FILTER_METACHARACTER_FIX(clientFileFilterGitignore_MetaCharFix) andFF_GITIGNORE_RESPECT_TRACKED_FILES(clientFileFilterGitignore_TrackedFilesRollout). The metacharacter fix is fully implemented in FileFilter; when enabled, paths containing regex metacharacters (e.g.OneDrive - Foobar (Team1)) no longer break .gitignore exclusions. The tracked-files flag is registered for platform rollout (CLI-1411).Where should the reviewer start?
cliv2/pkg/core/logheaderfooter.gocliv2/pkg/core/workflows.goHow should this be manually tested?
Test behaviour with the
FF_FILE_FILTER_METACHARACTER_FIXemabled and disabled.What's the product update that needs to be communicated to CLI users?
Two new feature flags available. Please check above for more information.
GAF PR: snyk/go-application-framework#675