Skip to content

Revert "ci: add publish-stable job with CircleCI OIDC, rename release.yml to legacy fallback" - #467

Closed
soniqua wants to merge 1 commit into
ci/IDE-2483_add-stable-release-workflowfrom
revert-464-ci/IDE-2483_add-publish-stable-job
Closed

soniqua wants to merge 1 commit into
ci/IDE-2483_add-stable-release-workflowfrom
revert-464-ci/IDE-2483_add-publish-stable-job

Conversation

@soniqua

@soniqua soniqua commented Sep 29, 2026 •

Copy link
Copy Markdown

Reverts #464


Note

Medium Risk
Stable releases no longer run from CircleCI publish jobs, so teams must use the GitHub Actions workflow again; the orphaned stable-release workflow may confuse operators until parameters or docs are cleaned up.

Overview
Reverts the CircleCI-based stable release path from #464 and restores GitHub Actions as the documented way to ship.

CircleCI: Drops the publish-stable job (GitHub release via gh, S3 stable upload), the github-cli orb, and persisting update-site-*.zip in the workspace. Preview publishing is unchanged except OIDC verification is inlined in publish-preview instead of a shared command. The stable-release workflow and run_stable_release parameter remain, but that pipeline no longer publishes after build-sign-stable.

Docs: RELEASE.md again instructs triggering the GitHub Actions release workflow; docs/release.md (CircleCI stable/preview process) is removed. .github/workflows/release.yml is renamed from the legacy label back to Release.

Reviewed by Cursor Bugbot for commit 0f8be4c. Bugbot is set up for automated code reviews on this repo. Configure here.

@soniqua
soniqua requested a review from a team as a code owner September 29, 2026 16:43
@snyk-io

snyk-io Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 2 relevant code sections from 2 files (average relevance: 0.48)

🤖 Repository instructions applied (from AGENTS.md)

@rrama

rrama commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Not needed — we're hard-resetting ci/IDE-2483_add-stable-release-workflow back to c4d98e0 (the commit before the accidental merge) and force-pushing, rather than landing a revert commit on top. Simpler history, same end state.

@rrama rrama closed this Sep 29, 2026
@rrama
rrama deleted the revert-464-ci/IDE-2483_add-publish-stable-job branch September 30, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants