Repository navigation
fix(android): EnrichedText ellipsizeMode regression - #828
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change matches existing behavior and has no identified blocking issues; Android E2E tests were not run.
No open issues 🎉
What changed in this PR
Fixes the Android EnrichedText ellipsizing regression introduced by line-height support in #724.
Changes:
- Uses
BufferType.NORMALwhen applying line height, matching existing text-setting behavior.
| File | Description |
|---|---|
| android/src/main/java/com/swmansion/enriched/text/EnrichedTextView.kt | Changes the text buffer type to restore ellipsizing. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lineHeightfeature for theEnrichedTextcomponent #724 introduced a regression. Precisely, theellipsizeModestopped working and the following e2e test was failing:.maestro/enrichedText/flows/ellipsize_mode.yamlFix turned out to be really simple - a
BufferTypechange when callingsetTextonlineHeightapply - consistent with howsetTextwas called elsewhere.Test Plan
Run the failing test, see it passes
Screenshots / Videos
Setting the
EnrichedTextvalue witha ab abc abcd abcde abcdef abcdefg abcdefgh abcdefghiBefore:
After:
Compatibility
Checklist