Repository navigation
🔒 Scrub environment variables for git commands in Worktree Tool - #304
Conversation
Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
This pull request is merged. |
Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
Refresh this existing proposal against current main and retain only its reviewed file scope. Amp-Thread-ID: T-01a1eca5-4ce4-7243-ad16-3240453f08af Co-authored-by: Max Carter <undivisible@vk.com>
Fresh hosted jobs cancel before checkout because macos-14 is unsupported. Use supported macos-15 in CI and release build matrices without changing gates, architecture targets or publication steps. Amp-Thread-ID: https://ampcode.com/threads/T-01a1eca5-4ce4-7243-ad16-3240453f08af Co-authored-by: Max Carter <undivisible@vk.com>
Change
Withhold Apollo configuration and AI/channel credentials from WorktreeTool's Git subprocesses. Preserve Git configuration, credential-helper/filter credentials, GitHub and Hugging Face tokens, and SSH agent access. Blanket secret-name scrubbing would break these supported Git integrations.
Refreshed against current main without restoring unrelated stale branch contents. The shared scrubber and plugin execution are unchanged.
Verification
The combined selected candidate passed 616 all-feature tests, 556 default tests, strict all-target/all-feature Clippy, and formatting. Real Git runs disposable worktree add/list/remove, a required checkout filter, checkout hook, and local credential helper with fake credentials only. The fixture clears the inherited environment and checks that its child test actually ran. No live authentication is claimed. Fresh hosted Linux/macOS checks are required before merge.
Combined source identity and gate evidence.
Original proposal created by Jules for task 14645121183593972423, started by @undivisible.
Summary by CodeRabbit