Skip to content

⚡ Optimize complete_task to avoid N+1 queries - #327

Merged
undivisible merged 4 commits into
mainfrom
jules-fix-complete-task-n1-1648751714277171177
Nov 18, 2026
Merged

undivisible merged 4 commits into
mainfrom
jules-fix-complete-task-n1-1648751714277171177

Conversation

@undivisible

@undivisible undivisible commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Change

Fetch blocker tasks once for the dependents affected by a completion, rather than fetching them separately for each dependent. Preserve existing completion, dependency, and failure semantics.

Add focused coverage using real local SurrealDB/RocksDB for multiple shared dependents, remaining and failed blockers, unrelated dependencies, completion results and failure errors, repeated completion preserving a claim, missing-task errors, and actual claim eligibility.

Verification

The combined selected candidate passed 616 all-feature tests, including all 12 swarm integration tests, plus 556 default tests, strict all-target/all-feature Clippy, and formatting. Swarm is opt-in; its default-feature empty target is not runtime coverage. No performance benchmark was run and no measured speedup is claimed. Fresh hosted Linux/macOS checks are required before merge.

Combined source identity and gate evidence.


Original proposal created by Jules for task 1648751714277171177, started by @undivisible.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2f6dba06-a145-46ae-ae88-b9eff5ac12df
Commits

Reviewing files that changed from the base of the PR and between 2e8e677 and 9947fea.

Files selected for processing: 4

  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • src/swarm/team.rs
  • tests/swarm_integration.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@mergify

mergify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

This pull request is merged.

ampagent and others added 3 commits November 18, 2026 06:43
Refresh this existing proposal against current main and retain only its reviewed file scope.

Amp-Thread-ID: T-01a1eca5-4ce4-7243-ad16-3240453f08af
Co-authored-by: Max Carter <undivisible@vk.com>
Fresh hosted jobs cancel before checkout because macos-14 is unsupported. Use supported macos-15 in CI and release build matrices without changing gates, architecture targets or publication steps.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1eca5-4ce4-7243-ad16-3240453f08af
Co-authored-by: Max Carter <undivisible@vk.com>
@undivisible
undivisible merged commit 73473ef into main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants