Repository navigation
fix(web): drop the internal scriptNonce/styleNonce exports; examples on vite-plugin next.50 - #4036
Merged
Merged
Conversation
…on vite-plugin next.50 @solidjs/vite-plugin 3.0.0-next.50 projects the CSP nonce locally (solidjs/solid-vite-plugin#409), so nothing imports these helpers any more. The examples move from their exact next.49 pin to next.50. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R2FCNsvaipU3xXx9p83VUs
🦋 Changeset detectedLatest commit: 16c3ebc The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Size (brotli, eager entry chunk)
Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in |
Coverage Report for CI Build 38460772654Coverage remained the same at 77.515%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Before:
@solidjs/web's server build still exportsscriptNonceandstyleNonce, marked@internal. They were kept only because@solidjs/vite-plugin≤ 3.0.0-next.49's generated start-mode handler imports them (see #4016). The examples pin the plugin to exactly3.0.0-next.49.After: both exports are gone. The two internal call sites use the existing local
destinationNonce. All 12 example package.json files pin@solidjs/vite-plugin3.0.0-next.50, which projects the nonce itself (solidjs/solid-vite-plugin#409).How: there's a patch changeset for
@solidjs/web, and the lockfile was regenerated withpnpm install.Testing:
solid-js,@solidjs/weband the compiler binding from this branch, then ranpnpm run buildfor the start-mode examples hackernews, todos-server, notes and board. All passed. These are the builds that broke when the exports were removed earlier.packages/webpnpm test: client 1391/1391 and hydrate pass. Server has 1 failure,server-functions-adapter-request.spec.tsx"keeps a rebuild failure's own error…", which fails the same way with this change stashed, so it isn't caused by this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01R2FCNsvaipU3xXx9p83VUs
Generated by Claude Code