You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The scheduled vulnerability triage started failing after the shared reusable workflow began requesting vulnerability-alerts: read.
Grant that permission in the caller so GitHub can start the reusable workflow and query Dependabot alerts.
Validation: YAML parsing and git diff --check pass.
Note
Low Risk
Changes are limited to GitHub Actions YAML; the Semgrep shift may miss findings covered only by the former custom ruleset.
Overview Vulnerability triage now declares vulnerability-alerts: read on the caller workflow so the shared reusable job from sourcebot-dev/sourcebot can run and read Dependabot alerts (fixes failures when the reusable workflow started requiring that scope).
Semgrep SAST is simplified: the job uses the semgrep/semgrep image, drops the extra checkout of sourcegraph/security-semgrep-rules, and runs semgrep scan --config p/default with SARIF output instead of a custom rules path, baseline commit, and semgrep ci flags.
Reviewed by Cursor Bugbot for commit 3c85000. Bugbot is set up for automated code reviews on this repo. Configure here.
Semgrep diagnosis: this Sourcebot fork has no repository secrets, and its available organization secrets do not include GH_SEMGREP_SAST_TOKEN; the referenced private sourcegraph/security-semgrep-rules repository is also inaccessible to the repository owner. The old check therefore had zero scanning coverage and failed every recent PR.
This PR intentionally restores coverage with Semgrep's documented public p/default ruleset, keeps metrics disabled, preserves PR differential scanning against the base SHA, and uploads SARIF even when the scan step fails. The repaired Semgrep job and GitHub code-scanning ingestion both passed on this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled vulnerability triage started failing after the shared reusable workflow began requesting
vulnerability-alerts: read.Grant that permission in the caller so GitHub can start the reusable workflow and query Dependabot alerts.
Validation: YAML parsing and
git diff --checkpass.Note
Low Risk
Changes are limited to GitHub Actions YAML; the Semgrep shift may miss findings covered only by the former custom ruleset.
Overview
Vulnerability triage now declares
vulnerability-alerts: readon the caller workflow so the shared reusable job fromsourcebot-dev/sourcebotcan run and read Dependabot alerts (fixes failures when the reusable workflow started requiring that scope).Semgrep SAST is simplified: the job uses the
semgrep/semgrepimage, drops the extra checkout ofsourcegraph/security-semgrep-rules, and runssemgrep scan --config p/defaultwith SARIF output instead of a custom rules path, baseline commit, andsemgrep ciflags.Reviewed by Cursor Bugbot for commit 3c85000. Bugbot is set up for automated code reviews on this repo. Configure here.