Fix featured widget review visibility - #2998
Open
RabbiIslamRony wants to merge 1 commit into
Open
RabbiIslamRony wants to merge 1 commit into
RabbiIslamRony wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
The Featured Listings widget rendered rating stars, rating points, and review counts even when Directorist reviews were disabled. This change makes the widget respect the global review setting while preserving the existing output when reviews are enabled.
How to reproduce the issue or how to test the changes
Before
https://prnt.sc/m_dKc0nKUrF9
After
https://prnt.sc/rjG5WCjOUhKK
Verification
php -l templates/widgets/featured-listing.phpcomposer phpcs -- --warning-severity=0 -- templates/widgets/featured-listing.php0rating-meta blocks; reviews enabled =1rating-meta block; the listing rendered in both states.pull_requestPHPCS workflow: passed.pull_request_targetcheck fails before scanning any file withYou must supply at least one file or directory to process; this is a default-branch workflow invocation issue, not a PHPCS violation in this PR.Any linked issues
TeamSync: https://team.sovware.com/support/directorist/3273
Help Scout: https://secure.helpscout.net/conversation/3370614583/5025
Checklist