fix: persist listing taxonomies for frontend submissions - #3031
Open
RabbiIslamRony wants to merge 2 commits into
Open
RabbiIslamRony wants to merge 2 commits into
RabbiIslamRony wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
Front-end listing authors can select categories, locations, and tags, but WordPress silently skips the
tax_inputassignment when the author does not have the taxonomy'sassign_termscapability. The listing is still created, so its taxonomy selections appear to disappear after submission.This change explicitly persists the term IDs that Directorist has already validated and normalized. It covers both new submissions and edits, retains empty-array clearing behavior, and leaves taxonomies absent from the submitted form unchanged.
How to reproduce the issue or test the changes:
publish_at_biz_dirs.Before
The listing is created, but the category and location term arrays are empty.
After
The same restricted-author flow stores both term IDs and the listing renders its saved category.
Verification
git diff --checkNote: the repository's current WordPressCS dependency aborts under PHP 8.5 before inspecting the files because of its own deprecated nullable parameter signature.
Any linked issues
Checklist