Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
The Listing Locations Elementor widget displayed pagination in list view, but clicking a page number did not replace the current locations. The list-view template did not expose the widget attributes required by the taxonomy pagination AJAX request and did not include the location wrapper targeted by the response handler.
This change adds the serialized taxonomy attributes to the list-view container and the expected
taxonomy-location-wrapperclass to the results row. The existing pagination script can now request the correct page and replace the rendered locations without reloading the page.How to reproduce the issue or test the changes:
6, and ensure enough locations exist for multiple pages.2in the location pagination.2becomes active, and subsequent/previous page controls continue to update the list without reloading the page.Local verification:
php -l templates/taxonomies/locations-list.phpphp tests/php/listing-taxonomy-subterms.phpgit diff --checkNotes:
Screenshots
Before
Pagination was displayed, but selecting another page did not update the visible locations.
After
Page 2 is active and the widget displays the next six locations after the local fix.
Any linked issues
Checklist