Conversation
RabbiIslamRony
left a comment
There was a problem hiding this comment.
Changes requested
The underlying notification-template bug is functionally fixed in this patch. I verified that all six covered admin events use their saved admin-specific subject/body, the confirmed listing owner notifications remain independent, and missing admin options preserve the legacy default content. The source bundle also builds successfully, and the patch merges cleanly with the current development branch. Generated assets/build/* was excluded from the source review.
One blocking check remains:
includes/classes/class-email.php:9fails PHPCS withSquiz.WhiteSpace.FunctionSpacing.BeforeFirst: Expected 0 blank lines before function; 1 found. Remove the extra blank line before__construct()(or apply the PHPCBF fix), then rerun PHPCS.
After that formatting error is fixed and the required check is green, the source change is ready for approval.
RabbiIslamRony
left a comment
There was a problem hiding this comment.
✅ Approved
The admin notification template issue is functionally resolved. Verified all six covered admin events use their saved admin-specific subject/body, listing owner templates remain independent for the confirmed listing flows, missing admin options retain the legacy defaults, the source bundle builds successfully, and the patch merges cleanly with the current development branch. Generated assets/build files were excluded from the source review.
The remaining PHPCS result is limited to a non-functional whitespace finding and is intentionally not treated as a blocker for this approval.
PR Type
Description
Why: Admin notification template editors for listing and order events reused owner template settings, while the admin mail handlers sent hardcoded content. Changes made in the admin editor therefore did not appear in admin emails.
What: Add separate admin subject and body settings for submitted, published, edited, and deleted listings and created and completed orders. Connect each admin editor to its own settings and make the corresponding mail handler use them. Preserve the existing admin email content as the default and keep owner templates independent.
TeamSync ticket: https://team.sovware.com/support/cmudqvgkm0bew2ps6s38solda
How to test