Update wasm-tools/wit-bindgen dependencies - #3712
Conversation
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
I trust you but there was one place where I didn't understand the change (left a comment).
| namespace: itf.namespace().to_string(), | ||
| name: itf.package().to_string(), | ||
| version: itf.version(), | ||
| version: itf.version(None)?, |
There was a problem hiding this comment.
What does the None do here?
There was a problem hiding this comment.
This corresponds to this method which I've apparently forgotten to document, but this is the versionsuffix field in the binary format, where here it's not relevant so None means "there's no prefix" and has the same previous behavior.
|
@alexcrichton Looks like the commits aren't GPG signed - could you oblige please? Sorry |
Keepin up-to-date Signed-off-by: Alex Crichton <alex@alexcrichton.com>
Head branch was pushed to by a user without write access
6ba861c to
88d16fd
Compare
|
Oops, done now! |
|
Is a known-flaky test? If not I can try to install redis and reproduce locally too |
|
It's a known flake. I've set it to re-run. |
2 participants
Keepin up-to-date