Conversation
…oke tests Signed-off-by: itaekyung <taeyun1411@gmail.com>
Signed-off-by: itaekyung <taeyun1411@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most smoke tests enable nullability checking for their tests, but the following ones don't:
spring-boot-smoke-test-jerseyspring-boot-smoke-test-secure-jerseyspring-boot-smoke-test-log4j2spring-boot-smoke-test-jackson2-mixedspring-boot-smoke-test-jackson2-onlyThis is similar to #51861 for
module/spring-boot-jersey.Enabling it for the first four didn't report any NullAway errors. For
spring-boot-smoke-test-jackson2-only, it reported 2 errors because the fields ofJsonPojoare populated through setters during deserialization and are never initialized. The fields and their accessors are now@Nullable, the same way asSampleDocumentinspring-boot-smoke-test-data-couchbase.spring-boot-smoke-test-antalso doesn't enable it, but its tests aren't in a@NullMarkedpackage, so I've left it out.The configuration is missing on 4.0.x as well, so I've based this on that branch.
./gradlew checkpasses locally for all five smoke tests with JDK 26.