fix(lattice): compile durable fragment tombstones - #4348
Open
mgazza wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
DurableFragmentAdapter.read_snapshot()intentionally fails closed after removal. The sealedregistry therefore persisted the removal invalidation but could not observe/acknowledge its
generation. A second coordinator was prototyped and rejected in review because it duplicated
existing restart, CAS, OFFLINE and superseded-candidate state machines.
This patch changes only the registry's private compiler-reader binding. Live states return the
exact original snapshot; durable tombstones become a schema-valid empty fragment at the same
provider/generation. Public
read_snapshot()andregistry.readersremain unchanged.Safety
ProviderSnapshot,compile_auto_config,LatticeAutoConfigCompiler, orCompiledLatticeCompilerchangescapabilities, or authority
OFFLINEstill follows the existing active-provider-unavailable LKG guardValidation
Train