refactor(mock): consolidate eleven per-module MockBase classes into a shared base

[springfall2008]

Summary

Eleven production modules each defined a near-identical MockBase class — a stand-in for the PredBat base object, used only to drive each module's standalone command-line harness (python fox.py --key=...). Roughly 90% of each copy was identical; the divergence was incidental drift from copy-paste, not intent.

This replaces all eleven with a single apps/predbat/mock_base.py:

• 5 plain imports — deye, enphase, fox, solis, teslemetry
• 5 subclasses — axle, gecloud, octopus (cache roots), gecloud (mock HA interface), sigenergy (readonly= seeding), solax (UTC clock)
• 1 alias — kraken (KrakenMockBase = MockBase)

Net: 588 duplicated lines removed, replaced by a ~125-line shared module plus ~40 lines of subclasses.

Latent bugs fixed

The drift had hidden four real defects on the CLI-harness path, none of which had automated coverage:

1. fox and solax had a narrow get_arg(key, default) — any call routed through ComponentBase.get_arg, which passes indirect/combine/attribute/index/domain/can_override/required_unit as keywords, would raise TypeError.
2. gecloud's getattr(self.base, "record_status", None) guard was always falsy — the mock had no record_status, so cloud auth-denied was silently never reported from the CLI.
3. fox, kraken and solis built a naive midnight_utc from datetime.now() alongside a timezone-aware now_utc, so now_utc - midnight_utc raised TypeError: can't subtract offset-naive and offset-aware datetimes.
4. The most-copied dashboard_item mutated its caller's dict — attributes["options"] = "..." was applied to the caller's own dict, which was then handed to set_state_wrapper and stored corrupted. kraken and sigenergy already avoided this with a display copy; the shared version adopts that.

Two further behaviours were unified deliberately: get_arg/set_arg now persist to and read from self.args everywhere (previously nine modules returned the bare default, with self.args empty in practice, so results are unchanged), and set_arg(key, None) now deletes the key to match userinterface.py.

Tests

New apps/predbat/tests/test_mock_base.py — 17 tests registered in TEST_REGISTRY. Beyond the per-method coverage, two are worth calling out:

• test_mock_base_covers_component_base_contract binds a real ComponentBase subclass to a MockBase and exercises every property and delegate, so it fails with AttributeError if someone adds a self.base.<x> dereference the mock doesn't cover. Verified non-vacuous: deleting an attribute makes it raise.
• test_mock_base_reexport_identity asserts the five re-export modules expose the shared class by identity and the five subclassing modules are subclasses of it — catching a botched future edit to any of those import lines.

kraken.py's import json and deye.py's from datetime import datetime became unused and were removed (verified with ruff F401).

Verification

• Full suite: ./run_all → exit 0, "All tests passed (total time: 102.38s)"
• ./run_pre_commit → all 10 hooks green

Notes

Out of scope by design: the test-local MockBase classes in tests/ (different surface, already shared where it matters) and web_mcp.py's inline mock (unrelated surface — no get_state_wrapper/get_arg at all).

Separately worth knowing: interrogate is configured with fail-under = 100 in pyproject.toml but is not wired into .pre-commit-config.yaml, so the 100% docstring rule in CLAUDE.md has never actually been gate-enforced. This branch satisfies it regardless — flagging as a pre-existing repo issue, not something to fix here.

Design and plan: docs/superpowers/specs/2026-07-29-shared-mock-base-design.md, docs/superpowers/plans/2026-07-29-shared-mock-base.md

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR consolidates eleven near-identical per-module MockBase CLI harness classes into a single shared apps/predbat/mock_base.py, reducing duplication and fixing drift-induced harness-only defects across vendor modules while keeping existing call sites intact.

Changes:

• Added a shared MockBase implementation (apps/predbat/mock_base.py) that satisfies the ComponentBase “base” contract and unifies previously divergent behaviours (e.g., get_arg signature breadth, timezone-aware midnight_utc, non-mutating dashboard_item, set_arg(None) deletion).
• Refactored 11 production modules to either re-export, subclass, or alias the shared MockBase (including KrakenMockBase aliasing and removing now-unused imports).
• Added and registered a focused unit-test suite (apps/predbat/tests/test_mock_base.py) to lock down the shared mock’s contract and module wiring, plus added design/plan docs for traceability.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
docs/superpowers/specs/2026-07-29-shared-mock-base-design.md	Design spec documenting scope, contract, and intentional behaviour unifications.
docs/superpowers/plans/2026-07-29-shared-mock-base.md	Implementation plan detailing migration steps and verification approach.
apps/predbat/mock_base.py	New shared MockBase used by standalone CLI harnesses; implements the superset contract and fixes drift bugs.
apps/predbat/tests/test_mock_base.py	New tests validating MockBase contract vs ComponentBase, wiring/identity across modules, and key behavioural guarantees.
apps/predbat/unit_test.py	Registers the new mock_base test suite in TEST_REGISTRY.
apps/predbat/axle.py	Replaces local mock with a small subclass of the shared base (custom cache root).
apps/predbat/deye.py	Replaces local mock with a direct re-export of the shared base; removes now-unused datetime import.
apps/predbat/enphase.py	Replaces local mock with a direct re-export of the shared base.
apps/predbat/fox.py	Replaces local mock with a direct re-export of the shared base (fixes prior narrow get_arg).
apps/predbat/gecloud.py	Replaces local mock with a subclass of the shared base (custom cache root + mock HA interface).
apps/predbat/kraken.py	Replaces KrakenMockBase with an alias to the shared base and removes unused json import.
apps/predbat/octopus.py	Replaces local mock with a subclass of the shared base (custom cache root).
apps/predbat/sigenergy.py	Replaces local mock with a subclass of the shared base and preserves readonly seeding behaviour.
apps/predbat/solax.py	Replaces local mock with a subclass pinned to UTC (fixes prior narrow get_arg).
apps/predbat/solis.py	Replaces local mock with a direct re-export of the shared base (fixes prior naive midnight_utc).
apps/predbat/teslemetry.py	Replaces local mock with a direct re-export of the shared base.