Skip to content

refactor: prefix the static extra query parameters field with s_ #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertospelta merged 1 commit into from
Oct 21, 2026
Merged

refactor: prefix the static extra query parameters field with s_ #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Infrastructure/PowerBI/Cloud/Authentication/CloudAuthenticationClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ internal sealed class CloudAuthenticationClient(IPolicyService policyService) :

// msafed=0 allows organizational accounts only (no Microsoft accounts). It filters the accounts offered at
// sign-in and does not change the token, so it stays out of the cache key.
private static readonly ReadOnlyDictionary<string, (string Value, bool IncludeInCacheKey)> ExtraQueryParameters = new(
private static readonly ReadOnlyDictionary<string, (string Value, bool IncludeInCacheKey)> s_extraQueryParameters = new(
new Dictionary<string, (string Value, bool IncludeInCacheKey)> { ["msafed"] = ("0", false) });

private readonly IPolicyService _policyService = policyService;
Expand Down Expand Up @@ -71,7 +71,7 @@ public async Task ClearTokenCacheAsync(CloudEnvironment environment)
private static async Task<Msal.AuthenticationResult> AcquireTokenSilentAsync(
IPublicClientApplication client, string[] scopes, string email, CancellationToken cancellationToken)
{
var extraQueryParameters = ExtraQueryParameters;
var extraQueryParameters = s_extraQueryParameters;
var loginHint = email;

var builder = client.AcquireTokenSilent(scopes, loginHint)
Expand All @@ -85,7 +85,7 @@ public async Task ClearTokenCacheAsync(CloudEnvironment environment)
{
var useSystemBrowser = _policyService.Current.UseSystemBrowserForAuthentication ?? UserPreferences.Current.UseSystemBrowserForAuthentication;
var useEmbeddedBrowser = !useSystemBrowser;
var extraQueryParameters = ExtraQueryParameters;
var extraQueryParameters = s_extraQueryParameters;
var prompt = Prompt.SelectAccount;
var loginHint = email;

Expand Down
Loading