test: follow the shipped lms_workers=2 default in pre-pool TAP rigs#34
Merged
Conversation
…AP rigs The spec-7.3 merge ships a default LMS worker pool of 2, which binds [data_port, data_port+1] per node. Two fallout classes in tests written against the pre-pool topology, caught by the first post-merge nightly: - t/004 kept 'lms worker' on its not-yet-spawned descriptor blocklist; the default pool now legitimately spawns exactly one. Move it to a positive assertion (count = 1 under the shipped default). - Nine hand-rolled 2-node rigs (t/078/288/289/334/335/336/337/339 and the shared-catalog t/346) reserve ONE data port per node, so the pool's second listener cross-wires consecutive free ports (HELLO DATA worker mismatch -> fail-closed boot; t/288 died this way in nightly run 29124665718). Pin cluster.lms_workers = 1 in each: N=1 is the spec-7.2 topology identity these rigs were written against, and none of them test the pool itself. Same fix class the merge already applied to t/366. Verified locally: t/004 t/078 t/288 t/289 green. Spec: spec-7.3-lms-worker-pool.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First post-merge nightly (run 29124665718, tag v-nightly-73-d4228f41f0) surfaced two fallout classes of the spec-7.3 default pool in tests written against the pre-pool topology:
Nightly reds outside this: stage4-wal / stage6-crossnode-a/b / stage6-storage / stage7-reconfig-liveness / stage5-integrated (t/328+t/334) = pre-existing main baseline (7.1 nightly run 29087550927 same set). New shards stage7-data-plane / stage7-multixact / stage7-lms-pool / write-write / dedup-capacity all GREEN on first run.
Test plan:
Spec: spec-7.3-lms-worker-pool.md