test: pin t/335's primaries before they start#36
Merged
Conversation
The PR#34 pin block for t/335 sat after the standby section, but the two primaries start earlier -- they still booted with the default 2-worker pool on single data ports (cross-wire, pg_ctl start failed, whole-shard bailout masking t/336-339). Move the primary pins ahead of their ->start. With the ordering fixed the file returns exactly to its PRE-merge failure shape (exit 29 after 10 tests -- the pre-existing ADG apply-master leg, red on main before the spec-7.3 merge in nightly run 29096781649), so the merge-added regression layer is gone and the remaining red is the known baseline. Spec: spec-7.3-lms-worker-pool.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the PR#34 pin for t/335: the pin block sat after the standby section while the primaries start earlier, so they still cross-wired (whole-shard bailout masking t/336-339 in nightly). With the ordering fixed the file returns exactly to its pre-merge failure shape (exit 29 after 10 tests -- the pre-existing ADG apply-master leg, red on main in pre-merge nightly 29096781649), i.e. the merge-added layer is gone and the remaining red is baseline.
Test plan:
Spec: spec-7.3-lms-worker-pool.md