test: give ClusterQuad the data_port_span reservation#37
Merged
Conversation
The spec-7.3 span root-fix covered ClusterPair and ClusterTriple but not ClusterQuad, which still reserves ONE data port per node -- under the shipped default pool of 2 the quad's worker listeners cross-wire consecutive free ports (racy: boot death or formation timeout, whichever port the allocator lands on). t/327 died both ways across nightly runs 29129633912 / 29138202141, bailing out the stage5-integrated-acceptance shard and masking t/328-331. Mirror the Triple implementation: reserve [data_port, data_port+span) per node, span default 2 following cluster.lms_workers = 2; six quad rigs (t/326/327/331/343/344/362) get the deterministic reservation. Verified locally: t/327 5/5 green. Spec: spec-7.3-lms-worker-pool.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the spec-7.3 span root-fix: ClusterQuad was missed (Pair/Triple covered), so quad rigs cross-wire worker listeners under the shipped default pool -- t/327 died at boot/formation in nightly 29129633912 and 29138202141, bailing the stage5-integrated shard and masking t/328-331. Mirror of the Triple implementation; t/327 locally 5/5 green.
Test plan:
Spec: spec-7.3-lms-worker-pool.md