Skip to content

spec-7.6 6.3b: DRM affinity collection substrate + admission hooks #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sqlrush wants to merge 4 commits into
base: main
Choose a base branch
from
Open

spec-7.6 6.3b: DRM affinity collection substrate + admission hooks #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f682a15
feat(cluster): spec-7.6 6.3b DRM affinity collection substrate + admi…
Jul 11, 2026
abb4897
test(cluster): sync t/030 pg_cluster_state category baseline for drm_…
Jul 11, 2026
e4597e4
feat(cluster): spec-7.6 6.3c DRM hotness decision scan + tumbling win…
Jul 11, 2026
c24b0f9
fix(cluster): renumber spec-7.6 6.3c value leg t/371 -> t/388 (id-led…
Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/backend/cluster/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ OBJS = \
cluster_cssd.o \
cluster_debug.o \
cluster_diag.o \
cluster_drm_affinity.o \
cluster_drm_decision.o \
cluster_drm_scan.o \
cluster_elog.o \
cluster_epoch.o \
cluster_extend_gate.o \
Expand Down
56 changes: 55 additions & 1 deletion src/backend/cluster/cluster_debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ PG_FUNCTION_INFO_V1(cluster_dump_state);
#include "cluster/cluster_undo_cleaner.h" /* dump_undo_cleaner (spec-3.13 D1) */
#include "cluster/cluster_lmon.h" /* cluster_lmon_status (spec-1.11 Sprint B D12) */
#include "cluster/cluster_guc.h"
#include "catalog/pg_control.h" /* DBState (spec-4.3 plan dump) */
#include "cluster/cluster_drm_affinity.h" /* spec-7.6 6.3b — drm_affinity dump */
#include "cluster/cluster_drm_decision.h" /* spec-7.6 6.3c — reason names for scan tally */
#include "catalog/pg_control.h" /* DBState (spec-4.3 plan dump) */
#include "cluster/cluster_recovery_plan.h"
#include "cluster/cluster_recovery_worker.h"
#include "cluster/cluster_recovery_merge.h" /* is_materialized (spec-4.5a D11) */
Expand Down Expand Up @@ -3150,6 +3152,57 @@ dump_xnode_profile(ReturnSetInfo *rsinfo)
* (values stay 0) so the key surface is stable for tests and samplers;
* later waves append keys, never rename (5.59 Q9-B category paradigm).
*/
/*
* dump_drm_affinity -- spec-7.6 6.3b DRM affinity collection observability.
* Pure counter surface (append-only keys; later waves add decision / anti-
* thrash keys, never rename — 5.59 Q9-B category paradigm).
*/
static void
dump_drm_affinity(ReturnSetInfo *rsinfo)
{
emit_row(rsinfo, "drm_affinity", "drm_enabled", fmt_int64(cluster_drm_enabled ? 1 : 0));
emit_row(rsinfo, "drm_affinity", "sample_epoch",
fmt_int64((int64)cluster_drm_affinity_get_sample_epoch()));
emit_row(rsinfo, "drm_affinity", "samples_recorded",
fmt_int64((int64)cluster_drm_affinity_get_counter(CLUSTER_DRM_AFFINITY_CTR_RECORDED)));
emit_row(rsinfo, "drm_affinity", "samples_local",
fmt_int64((int64)cluster_drm_affinity_get_counter(CLUSTER_DRM_AFFINITY_CTR_LOCAL)));
emit_row(rsinfo, "drm_affinity", "samples_remote",
fmt_int64((int64)cluster_drm_affinity_get_counter(CLUSTER_DRM_AFFINITY_CTR_REMOTE)));
emit_row(
rsinfo, "drm_affinity", "samples_skipped_off",
fmt_int64((int64)cluster_drm_affinity_get_counter(CLUSTER_DRM_AFFINITY_CTR_SKIPPED_OFF)));
emit_row(
rsinfo, "drm_affinity", "samples_dropped_stale_epoch",
fmt_int64((int64)cluster_drm_affinity_get_counter(CLUSTER_DRM_AFFINITY_CTR_DROPPED_STALE)));
emit_row(
rsinfo, "drm_affinity", "flush_batches",
fmt_int64((int64)cluster_drm_affinity_get_counter(CLUSTER_DRM_AFFINITY_CTR_FLUSH_BATCHES)));

/* spec-7.6 6.3c decision-scan surface: run / candidate / proposal totals plus
* a per-reason verdict tally (stable key "scan_" + ClusterDrmReason name). */
emit_row(
rsinfo, "drm_affinity", "scans_run",
fmt_int64((int64)cluster_drm_affinity_get_scan_counter(CLUSTER_DRM_AFFINITY_SCAN_RUNS)));
emit_row(rsinfo, "drm_affinity", "scan_candidates",
fmt_int64((int64)cluster_drm_affinity_get_scan_counter(
CLUSTER_DRM_AFFINITY_SCAN_CANDIDATES)));
emit_row(rsinfo, "drm_affinity", "scan_proposed",
fmt_int64(
(int64)cluster_drm_affinity_get_scan_counter(CLUSTER_DRM_AFFINITY_SCAN_PROPOSED)));
{
int r;

for (r = 0; r < DRM_REASON__COUNT; r++) {
char key[64];

snprintf(key, sizeof(key), "scan_%s", cluster_drm_reason_name(r));
emit_row(rsinfo, "drm_affinity", key,
fmt_int64((int64)cluster_drm_affinity_get_scan_reason(r)));
}
}
}

static void
dump_xnode_lever(ReturnSetInfo *rsinfo)
{
Expand Down Expand Up @@ -3321,6 +3374,7 @@ cluster_dump_state(PG_FUNCTION_ARGS)
dump_write_fence(rsinfo);
dump_hw(rsinfo);
dump_dl(rsinfo);
dump_drm_affinity(rsinfo); /* spec-7.6 6.3b */
dump_ir(rsinfo);
dump_ts(rsinfo);
dump_ko(rsinfo);
Expand Down
Loading