Repository navigation
[study] GEORGE2023_HEATWAVE_PLOIDY: rerun on main's single-end code - #62
Merged
Merged
Conversation
The committed results came from the pre-merge single-end code (fastp auto-detected the adapter); main trims an explicit adapter (--se_adapter), so they were not reproducible from main. All four comparisons rerun on main and the tables, manifests and reports replaced. The change is negligible: fold changes r = 0.998-0.999 with the first run, DE counts move by 2-8 genes, author concordance and replicate dispersion unchanged. Harmonized 100,245 records. process_versions.yml removed: the manifests now record the real tool versions and se_adapter. A test pins se_adapter in every manifest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18, which merged on 2026-10-15 with outputs from the branch's pre-merge single-end code. In that code fastp auto-detected the single-end adapter.
maintook a different single-end implementation (#25) that trims an explicit adapter (--se_adapter, default TruSeq read 1), so #18's committed results could not be reproduced frommain.What this does
main: Nextflow 26.04.7, native, on Hete. FastQC and the Salmon index came from cache; fastp, Salmon quant and DESeq2 were rerun.process_versions.yml. Since Build manifest software_versions from what actually ran #19 the manifests record the tools that actually ran, and they now also recordse_adapter.main's adapter, so the gap can't silently return.How much changed: almost nothing
SRR22817776, for example, 2 of 1.67 M mapped reads and 91 transcripts change. For 3′ tags the poly-A trimming, which was already on, dominates.Checklist
aree validate-studypassescheck-study-scopepasses; only study-owned files changework/orresults/committed🤖 Generated with Claude Code