Repository navigation
Conversation
App stores attach their own terms to every copy, and the GNU AGPL forbids further restrictions on recipients. Sourceful owns all code here today, so it may publish through the App Store as it is. That stops being true once someone else's code comes in under plain AGPL. LICENSE gains a second section 7 permission, next to the Energyplan one. It allows conveying the app through a store such as the App Store, TestFlight or Google Play despite the store's terms. Every other AGPL condition stays: source for the exact version outside the store, license and source offer reachable in the app, no added restrictions, and installation information except the distributor's own signing keys. CONTRIBUTING now says each contribution grants both permissions, so the permission covers future code as well. LICENSING.md and the README say the same in plain words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 12, 2026
Member
Author
|
Included in #14, which lands the whole iPhone M1 app as one PR. The branch stays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The App Store attaches Apple's terms to every copy it delivers. GNU AGPL §10 forbids further restrictions on recipients, and the FSF counts the App Store terms as such a restriction. VLC was pulled from the App Store in 2011 after one of its copyright holders objected.
Today Sourceful's own code is the whole app (all commits on
mainare Fredrik's), and a copyright holder is not bound by its own license. So publishing the app is fine as it stands. That stops being true when the first outside contribution arrives under plain AGPL. A permission cannot be added later to code that is already in without every contributor's consent, so it goes in now.Change
LICENSEgains a second §7 additional permission, the app store distribution permission. It sits next to the Energyplan combination permission and has the same form. It allows conveying object code through a service such as the App Store, TestFlight or Google Play, even where that service's terms would otherwise conflict with the AGPL. It covers only restrictions that come from the service's own terms and technical measures.CONTRIBUTING.mdsays each contribution grants both permissions, so future code is covered.LICENSING.mdandREADME.mdstate the same in plain words. The old paragraph in LICENSING.md, which said no store exception exists, is replaced.Modelled on Nextcloud's iOS commitment (
COPYING.iOS, nextcloud/ios) and on this repo's existing Energyplan permission. Fredrik asked for this text on 2026-10-12. No lawyer has reviewed it.Follow-up for the iPhone app (not in this PR)
The Swift app in #8 defines
Origin.sourceURLandOrigin.licenseURLbut shows neither. The license link also points atmain, where it should point at the build's commit. Before a build reaches anyone outside the team, through TestFlight or the App Store, the app needs a "Source & licenses" view with the bundled license text and a source link pinned to the build's commit. Android already has one (MainActivity.kt:207-212). This is a condition of the permission.Evidence
Text-only change.
mainhas no CI workflow that reads these files. The diff touches onlyLICENSE,LICENSING.md,CONTRIBUTING.mdandREADME.md.The commit has no DCO sign-off. Fredrik signs off his own work.
🤖 Generated with Claude Code