Repository navigation
registry: copy the cars' names from srcfl/ftw-webapp - #70
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87e63847b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PushKind.boxUnreachable: Sentence(title: "Your box is out of reach", body: "It stopped answering. Power cut, or the internet at home is down."), | ||
| PushKind.cloudGranted: Sentence(title: "FTW Cloud is on", body: "Your box now shares a copy of its readings with FTW Cloud. You can turn it off in the app or on the box."), | ||
| PushKind.cloudRevoked: Sentence(title: "FTW Cloud is off", body: "Your box stopped sharing with FTW Cloud and asked it to delete its copy."), | ||
| PushKind.carWhich: Sentence(title: "Which car is plugged in?", body: "Tap the car so the box plans for its level and goal."), |
There was a problem hiding this comment.
car.which
When a box emits the newly accepted car.which event, the notification tells the user to tap a car, but PushActions.category(for:) returns nil for this kind—and the existing button test explicitly expects that—so PushNotice supplies no car buttons or category. This leaves the user unable to answer the prompt with session.car.set, and the box cannot plan for the correct car; either add the promised selection flow in this release or keep this kind generic until that flow exists.
Useful? React with 👍 / 👎.
b6f2e45 to
53bb2d9
Compare
The car, its level and goal, the car ops, how the box knows which car is on a charger, and the car.which push with its words in English and Swedish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
53bb2d9 to
8f08bf9
Compare
1 participant
What
Copies the cars' names from srcfl/ftw-webapp#92 into
protocol/registry.yaml, byte for byte, andcar.whichintoprotocol/push-catalogue.yaml. Rebased onto main (after #69, #73, #75) as one commit. The catalogue here still lacks the agents' five push kinds, as on main: copying them needs their Swedish words, which belong with the agents' app work. A car belongs to its owner, not to the home; the design isdesign/vehicles/car-entity-2026-10-15.mdin the FTW stack workspace, and the wire isdocs/cars.mdin srcfl/ftw.Contract.swift: the car ops, the scopesftw.cars.readandftw.cars.write(owner only), the capabilityder.car, the car's field names, where its level comes from, how the box knows which car is on a charger (includingasking), the charger's car fields (includingsessionandchoose), and the refusalE_DUPLICATE(E_NOT_FOUNDcame with registry: copy the agents' names from srcfl/ftw-webapp #69).car.whichin English (the catalogue's) and Swedish: "Vilken bil är inkopplad?" / "Tryck på bilen så planerar boxen efter dess nivå och mål." The buttons, one per car, come with the car view (design step 4).ContractTestsreads the car blocks back. Locally:swift test --filter ContractTestspasses (6 tests).Nothing on screen changes.
Paired PRs
docs/cars.md.Merge order: srcfl/ftw-webapp#92, then srcfl/ftw#1647 and this PR, then srcfl/ftw#1650.
Tests
CI's "FTWKit and the iPhone app" (
swift testand the app build) passes,ContractTestsandPushTextTestsincluded. I did not run them locally: other sessions held the laptop's Swift toolchain.🤖 Generated with Claude Code