Repository navigation
push: copy the agents' kinds from srcfl/ftw's catalogue - #78
Merged
Merged
Conversation
srcfl/ftw#1642 added agent.added, agent.request, agent.expiring, approval.key.set and owner.added to the push catalogue; the app's copy missed them, so srcfl/ftw's 'the registry has not drifted from the app' check is red on master. The catalogue is copied byte for byte, with the English it holds and the Swedish beside it. These kinds are owners' news and come as the box's notice: as an event they reach viewers too, so an event that names one reads as generic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
frahlg
added a commit
that referenced
this pull request
Oct 16, 2026
The notification extension reads a box-signed notice in an alert as an event of its kind, for a day, since a notice states a lasting fact. It checks the notice as Go's ReadNotice does: a 16-byte boot, and on agent.added a client's name of at most the consent page's 64 characters and its "…", with no control or format character. A notice kind sent as an event still reads as generic (#78). agent.added names the client when the box sent one: "Claude was given access to your box". An owner's phone registers for FTW Cloud's alerts whenever the box is linked, so notices reach it with the readable copy off. PushSeen keeps the numbers it showed per boot, the newest 64 above a floor, so a notice that arrives after a later event is shown, not quieted as a repeat. A file from before keeps its highest as the floor. CloudView holds the car class and joins a charger to its session's car by carId, the car winning where the two disagree. socReadAtMs dates the level from the car class's own send. The push vectors and the cloud vectors are srcfl/ftw's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
frahlg
added a commit
that referenced
this pull request
Oct 16, 2026
…ew (#77) * iPhone: security notices from FTW Cloud, and the car class in CloudView The notification extension reads a box-signed notice in an alert as an event of its kind, for a day, since a notice states a lasting fact. It checks the notice as Go's ReadNotice does: a 16-byte boot, and on agent.added a client's name of at most the consent page's 64 characters and its "…", with no control or format character. A notice kind sent as an event still reads as generic (#78). agent.added names the client when the box sent one: "Claude was given access to your box". An owner's phone registers for FTW Cloud's alerts whenever the box is linked, so notices reach it with the readable copy off. PushSeen keeps the numbers it showed per boot, the newest 64 above a floor, so a notice that arrives after a later event is shown, not quieted as a repeat. A file from before keeps its highest as the floor. CloudView holds the car class and joins a charger to its session's car by carId, the car winning where the two disagree. socReadAtMs dates the level from the car class's own send. The push vectors and the cloud vectors are srcfl/ftw's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * push: agent.added says access was given, not who gave it The catalogue from srcfl/ftw-webapp#94, and the same in Swedish. The named line stays the phone's own, from the notice's client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srcfl/ftw#1642 added five owner-only kinds (agent.added, agent.request, agent.expiring, approval.key.set, owner.added) to
contract/push-catalogue.yaml; this repository's copy missed them, so srcfl/ftw's drift check fails on master and blocks every open Core PR.protocol/push-catalogue.yamlcopied byte for byte from srcfl/ftw master (same as srcfl/ftw-webapp main).PushKindandPushTextcarry the five kinds, the catalogue's English and the phone's Swedish;PushTextTestsholds them to the file.notice(feat(cloud): security notices for every owner's phone, naming the client only while the copy carries events ftw#1661, iPhone: security notices from FTW Cloud, and the car class in CloudView #77). Aneventthat names one also reaches viewers, so it reads as generic:accessNewsAsAnEventIsGeneric.swift test --filter 'PushTextTests|PushAlertTests': 26 passed. The neutral wording asked for in review ("{client} was given access to your box") follows as a catalogue change, webapp first, in the notices PRs.🤖 Generated with Claude Code