Repository navigation
HTTP/3 for the plain HTTPS routes, on UDP 443 beside TCP (QUIC step 1) #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "crypto/tls" | ||
| "errors" | ||
| "flag" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "net/url" | ||
| "time" | ||
|
|
||
| "github.com/quic-go/quic-go/http3" | ||
| ) | ||
|
|
||
| // health checks /healthz over TCP and over HTTP/3, the way the container's | ||
| // health check and an operator's laptop run it: | ||
| // | ||
| // ftwcloudd health -name cloud.ftw.energy https://127.0.0.1/healthz | ||
| // ftwcloudd health https://cloud.ftw.energy/healthz | ||
| // | ||
| // Each line names the protocol that answered and how long it took. Either | ||
| // failing fails the check: a host whose UDP is shut while Alt-Svc says | ||
| // HTTP/3 is there makes every client race for nothing. | ||
| func health(args []string) error { | ||
| fs := flag.NewFlagSet("health", flag.ExitOnError) | ||
| name := fs.String("name", "", "the certificate's name, when the URL names an address") | ||
| insecure := fs.Bool("insecure", false, "accept any certificate (local tests only)") | ||
| h3 := fs.Bool("h3", true, "check HTTP/3 too") | ||
| _ = fs.Parse(args) | ||
| if fs.NArg() != 1 { | ||
| return errors.New("usage: ftwcloudd health [-name host] [-h3=false] https://host/healthz") | ||
| } | ||
| u, err := url.Parse(fs.Arg(0)) | ||
| if err != nil || u.Scheme != "https" { | ||
| return fmt.Errorf("health: %q is not an https URL", fs.Arg(0)) | ||
| } | ||
| tlsConf := &tls.Config{MinVersion: tls.VersionTLS13, ServerName: *name, InsecureSkipVerify: *insecure} | ||
| tcp := &http.Transport{TLSClientConfig: tlsConf.Clone(), DisableKeepAlives: true} | ||
| defer tcp.CloseIdleConnections() | ||
| clients := []*http.Client{{Transport: tcp}} | ||
| if *h3 { | ||
| quic := &http3.Transport{TLSClientConfig: tlsConf.Clone()} | ||
| defer quic.Close() | ||
| clients = append(clients, &http.Client{Transport: quic}) | ||
| } | ||
| for _, c := range clients { | ||
| c.Timeout = 5 * time.Second | ||
| start := time.Now() | ||
| proto, err := get(c, u.String()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| fmt.Printf("%s ok in %d ms\n", proto, time.Since(start).Milliseconds()) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func get(c *http.Client, u string) (string, error) { | ||
| req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, u, nil) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| resp, err := c.Do(req) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| defer resp.Body.Close() | ||
| body, _ := io.ReadAll(io.LimitReader(resp.Body, 64)) | ||
| if resp.StatusCode != http.StatusOK || string(body) != "ok\n" { | ||
| return resp.Proto, fmt.Errorf("health: %s answered %d", resp.Proto, resp.StatusCode) | ||
| } | ||
| return resp.Proto, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
Door.Serveexits with a fatal UDP or QUIC listener error, this path only logs it while the TCP server keeps emitting the unchangedAlt-Svcheader. The inspecteddeploy/compose.ymlhealth check can mark the container unhealthy, but the deployment documentation explicitly says that nothing restarts on that state, so clients can keep racing a dead HTTP/3 endpoint indefinitely. Propagate this error to terminate the process, or otherwise stop advertising HTTP/3.Useful? React with 👍 / 👎.