Repository navigation
feat(ev): show the ready time on the household clock - #78
Merged
Merged
Conversation
Read time_of_day_min when the box sends it, so a phone in another time zone shows and saves the time at home. Send it with the UTC minute, so an older box still works. The sim keeps the household clock the way the box does. The old note that a DST change moves the deadline was wrong since srcfl/ftw#1582. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | d506a84 | Commit Preview URL Branch Preview URL |
Oct 12 2026, 03:22 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app shows the car's ready time by turning the box's
time_of_day_min_utcinto a clock time with today's offset in the phone's zone. A phone abroad shows and saves the wrong time at home. srcfl/ftw#1586 addstime_of_day_min, the ready time on the household clock.Change
toLoadpointreadstime_of_day_minintoschedule.timeOfDayMinwhen it is present and in range; null from an older box.readyClockandreadyInputshow the household minute as it is. Without it they fall back tolocalClockandutcMinutesToLocalInput, as before.time_of_day_minandtime_of_day_min_utc. A box with feat(api): send the EV ready time on the household clock ftw#1586 uses the first; an older box reads the second, as today.localInputToUtcMinutessaid a DST change moves the deadline. That stopped being true with fix(loadpoint): keep the EV ready time on the household clock ftw#1582; the comment now says what the UTC minute is for.Paired with srcfl/ftw#1586. Either side can merge first: this app against an older box sends the UTC minute it always sent, and an older app against the new box is an old client the box still serves.
contract/registry.yamldoes not change. Fields of HTTP bodies are not registry names;time_of_day_min_utcis not there either.Evidence
npm run verifypasses: 1062 tests, svelte-check and build.src/lib/format/ev.test.ts,src/views/EvPanel.svelte.test.tsandtests/api-passthrough.test.tspass withTZset to Europe/Stockholm, America/New_York and Asia/Kolkata.🤖 Generated with Claude Code