Repository navigation
Read a v3 pairing code: v2 and the home id at FTW Cloud - #89
Merged
Merged
Conversation
The box's QR adds the home id as a sixth segment once Core flips appenroll.QRNamesHome. Each parser that ships must read v3 before then, so this one does, and keeps reading v2. The app does not use the home id yet; the browser session moves to FTW Cloud in a later step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 15, 2026
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | 9a1ea91 | Commit Preview URL Branch Preview URL |
Oct 15 2026, 03:46 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
enrollment.tsreads a v3 pairing code as well as v2:v3 is v2 with a sixth segment, the home id at FTW Cloud as base64url of its 26 characters (srcfl/ftw
docs/protocol-cloud.md, "Pairing through the service"). The parser takes only a home id FTW Cloud could have cut (26 characters of lowercase base32) and refuses anything else asE_QR_HOME.buildEnrollmentUrlwrites v3 when the enrollment names a home, else v2. A v4 code now says "update the app", as v3 did before.The web app does not use the home id yet. This PR is one of three parsers that must ship before Core turns
appenroll.QRNamesHomeon; a v3 QR before then stops pairing on every shipped app. This PR does not flip it.Paired PRs (one-door plan, step 2)
Enrollment.swiftandEnrollment.ktread the same v3 string as this test, byte for byte.cloud.tuncapability and thetunnelcarrier.Tests
enrollment.test.ts: the shared v3 string parses and builds back to itself; v2 stays v2 with no home; a v3 code without a home, with a seventh segment, a v2 code with a sixth, a home that is not a home id, and a segment that is not base64url are each refused with their code.npx vitest run src/lib/identity src/views(271 tests) andnpm run checkgreen locally.🤖 Generated with Claude Code