Repository navigation
fix(web): keep live markers off old history segments - #1593
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e4525aa1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (sr.width >= 2 && pts.length && sr.data.length === chartHistory.timestamps.length) { | ||
| liveTips.push({ x: pts[pts.length - 1].x, y: pts[pts.length - 1].y, color: sr.color }); |
There was a problem hiding this comment.
This changes visible canvas behavior, but the added VM tests only inspect the cached coordinates and never render the marker; the commit also explicitly defers human UI inspection. A human needs to inspect the gap and latest-null states in a browser before accepting this change, since clipping, layering, and marker appearance are not covered by these assertions.
AGENTS.md reference: AGENTS.md:L129-L131
Useful? React with 👍 / 👎.
1 participant
After a gap in Live history, old segment endpoints receive the same pulse as the current reading. This can make a measurement before an outage look fresh.
Cache only the endpoint at the latest sample. A missing latest sample leaves all old points still, and the first known point after a gap can pulse. The history lines and missing-value gaps stay intact.
Two regressions execute the actual chart drawing block. They fail before the change and pass after it; all 715 web tests pass. Full
make verifyalso passes. Human UI inspection remains deferred to the owner's beta review. This addresses the final review finding on #1592.