Repository navigation
fix(charging): limit charge steps and show planning failures - #1600
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
marked this pull request as ready for review
October 13, 2026 05:28
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
A charger with an 11,000 W limit and an 11,100 W allowed step passed config validation, then stopped every planning attempt. Plan stayed on “Preparing” and hid the cause.
FTW now reduces steps above the charger limit to that limit and removes duplicates. Loading, saving and planning all apply this rule. Settings saves the corrected values, puts them back in the field and shows a warning. Plan keeps working and shows the warning. Other planning failures now show their actual cause; a successful retry clears the error.
Scope and safety
The correction only lowers charging power. Core still validates the resulting plan and commands, and stale meter data still stops dispatch. Failed replans keep old diagnostics but do not resume dispatch from the old plan. An older attempt cannot overwrite the latest error or warning.
Based on current master, d570ab7. Open PR #1177 also touches web/plan.js: its Plan polling changes already entered master in #1225 (e5f281f). This patch keeps that code and its tests intact. #1003 and #1051 change other config fields; #1337 and #1595 add other API handlers.
Verification
a4717ffe: all seven workflows, including Go, web, full-stack tests and both Linux builds.make verifypassed: Go tests, vet, build, protocol boundary, install/release fixtures and bundled Energyplan checks.npm test: 719 tests passed.The repository owner requested merge and a beta release on 2026-10-13 with green CI. This uses the owner fast-track allowed by AGENTS.md. Human browser review remains deferred; the local preview uses test data.
Checklist