Skip to content

fix(drivers): bundle sungrow 1.6.0, read once a second - #1619

Merged
frahlg merged 1 commit into
masterfrom
claude/pin-sungrow-1hz
Oct 14, 2026
Merged

frahlg merged 1 commit into
masterfrom
claude/pin-sungrow-1hz

Conversation

@frahlg

@frahlg frahlg commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Problem and result

Bundle sungrow 1.6.0 from srcfl/device-drivers#179 so the next beta reads the
Sungrow site meter once a second. #1616, now on master, makes Core
honour the interval a driver returns from driver_poll; this moves the pin
to the merged commit that uses it.

The pin moves from c9de251 to afc9739 (srcfl/device-drivers#179). The only bundled driver that changes:

Driver Before After
sungrow 1.5.10, every 5 s 1.6.0: power, SoC, per-phase values and EMS readback every second; counters, temperature, frequency and fault bits every 5 s

The only other commit between the pins is srcfl/device-drivers#168, which
changes tests, not drivers.

Scope and safety

  • sungrow 1.6.0 carries counters and other slow values between full reads,
    and only on a poll whose own power read succeeded, so FTW's energy ledger
    does not start over and nothing outlives the device.
  • Two tests in sungrow_driver_test.go polled back to back and expected the
    running state on every poll. sungrow 1.6.0 reads it on a full read every
    5 s, timed by host.millis, so the tests now move the driver's clock 5 s
    before each poll. In real time a fault clears at the next full read, within
    5 s, as it did when every poll was 5 s apart.
  • sdm630 and pixii_pv are unchanged here. With fix(drivers): honour the interval driver_poll returns #1616 they already run at the
    1 s their drivers return; the owner accepted that.

Overlap: two open drafts also move this pin. #1537 pins an
unmerged commit of srcfl/device-drivers#172; once #172 merges, its pin goes
to a main commit after afc9739 and takes this change with it.
#1449 pins eeb3e06, which is older than the current pin. Neither
can be rebased onto here, so the second one to merge resolves one line.

Verification

Checklist

  • The change follows VISION.md and one selected scope.
  • I checked overlapping PRs and coordinated shared files/contracts.
  • Relevant checks cover the changed behaviour and failure paths.
  • A human reviewed changed UI in a browser, or no UI changed. No UI changed.
  • A Changeset is included, or the change is exempt. Patch.
  • Every commit has a DCO sign-off.

🤖 Generated with Claude Code

Move the pin to srcfl/device-drivers afc9739 (#179). Two Sungrow tests
polled back to back and expected the running state on every poll;
1.6.0 reads it on a full read every five seconds, so they move the
driver's clock five seconds before each poll.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T06:23:28.396190Z 2cfe81d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frahlg
frahlg merged commit 4d9018a into master Oct 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant