Repository navigation
fix(drivers): bundle sungrow 1.6.0, read once a second - #1619
Merged
Merged
Conversation
Move the pin to srcfl/device-drivers afc9739 (#179). Two Sungrow tests polled back to back and expected the running state on every poll; 1.6.0 reads it on a full read every five seconds, so they move the driver's clock five seconds before each poll. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Bundle sungrow 1.6.0 from srcfl/device-drivers#179 so the next beta reads the
Sungrow site meter once a second. #1616, now on master, makes Core
honour the interval a driver returns from
driver_poll; this moves the pinto the merged commit that uses it.
The pin moves from
c9de251toafc9739(srcfl/device-drivers#179). The only bundled driver that changes:The only other commit between the pins is srcfl/device-drivers#168, which
changes tests, not drivers.
Scope and safety
and only on a poll whose own power read succeeded, so FTW's energy ledger
does not start over and nothing outlives the device.
sungrow_driver_test.gopolled back to back and expected therunning state on every poll. sungrow 1.6.0 reads it on a full read every
5 s, timed by
host.millis, so the tests now move the driver's clock 5 sbefore each poll. In real time a fault clears at the next full read, within
5 s, as it did when every poll was 5 s apart.
1 s their drivers return; the owner accepted that.
Overlap: two open drafts also move this pin. #1537 pins an
unmerged commit of srcfl/device-drivers#172; once #172 merges, its pin goes
to a main commit after
afc9739and takes this change with it.#1449 pins
eeb3e06, which is older than the current pin. Neithercan be rebased onto here, so the second one to merge resolves one line.
Verification
14 Oct: 19,040 Modbus reads, none failed, median 2 ms per read, meter value
new every 1020 ms. Details in feat(sungrow): read live values once a second (1.6.0) device-drivers#179.
scripts/sync-bundled-drivers.shat the new pin, thenmake verifyonthis branch, based on master after fix(drivers): honour the interval driver_poll returns #1616: green.
Checklist
🤖 Generated with Claude Code