Repository navigation
fix(optimizer): retain legal future EV charging headroom - #1651
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker could exclude a legal future EV charging step from its planning reserve and charge earlier at a higher price. The updated worker keeps that step available while retaining grid limits, actual charger pulses and departure goals.
Pin the compiled workers from private source commit
38c4872a5f646e0b822f7645ae06f3b454a8ffea(srcfl/energyplan#77), for Energyplanv0.5.2-beta.2. The worker handshake remains 0.5.2 and both protocols remain v1. The bundle contains Linux ARM64, Linux AMD64 and macOS ARM64 executables, with their complete licenses, notices and checksum manifest.Validation:
make native-solver-testand fullmake verifypassed with the replacement bundle. The separate fix(mpc): keep valid plans when forecast caution fails #1644 Core fixes also passed whole MPC, forecast and entrypoint race suites against this exact worker.The separate PV-independent intermediate reserve preference remains and can still favor earlier charging over a cheaper PV-dependent schedule. This update removes the extra headroom margin; it does not claim the cheapest schedule under physics alone. Core's guard that retains a valid point plan when optional forecast caution fails is separate in #1644.
Private worker release: https://github.com/srcfl/energyplan/releases/tag/v0.5.2-beta.2.
A standalone run of the exact Linux ARM64 artifact on
homelab-rpipassed three synthetic cases: a cheap legal later step, one watt too little headroom, and a genuinely unreachable goal with a 1000 Wh shortfall. A separate Wh, power and cost replay passed. The run issued no hardware commands and did not update the running Core.