Skip to content

fix(drivers): bundle the vehicle drivers that say where a car is plugged in - #1665

Merged
frahlg merged 1 commit into
masterfrom
claude/pin-vehicle-drivers
Oct 16, 2026
Merged

frahlg merged 1 commit into
masterfrom
claude/pin-vehicle-drivers

Conversation

@frahlg

@frahlg frahlg commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Moves the device-drivers pin from 76ddd58 to 5cc7bb1a (srcfl/device-drivers#182) and bundles the vehicle drivers, so the next beta ships them with the Core side that reads them (#1660).

Supersedes #1449, the 26 September draft that proposed bundling teslamate_vehicle, tesla_cloud and vag_vehicle at an older pin. It can be closed.

What changes

Driver Version Cable Place
home_assistant_vehicle 0.1.0, new plugged, and plugged_since if the automation sends it at_site from a tracker in zone home
tesla_cloud 0.2.0 plugged, no cable time site_distance_m from location_data
teslamate_vehicle 0.2.0 plugged, dated only with a live healthy at_site from the configured geofence, else site_distance_m
vag_vehicle 0.3.0 plugged, no cable time none
tesla_vehicle 0.2.6 — —

All five send a level of 1 % or less as a fraction. None wakes a car; each does nothing until configured.

Note on the place. host.site_location() answers only a driver whose signed catalog entry lists vehicle (#1660). A bundled copy runs without that signed entry, so a bundled tesla_cloud or teslamate_vehicle sends no site_distance_m. TeslaMate's geofence and Home Assistant's zone still give at_site. The same drivers installed from the signed channel get the distance. Extending the gate to bundled copies is a small Core change if wanted.

Evidence

  • scripts/sync-bundled-drivers.sh wrote 44 drivers from 5cc7bb1a. All five vehicle drivers are byte-identical to device-drivers main.
  • scripts/check-driver-versions.sh origin/master: "driver version changes verified across 44 bundled drivers".
  • scripts/sync-bundled-drivers.sh --check: no driver source committed.
  • go test -p 2 ./internal/drivers ./internal/fleetping: pass, including TestBundledDriversMeetStartupContract and the end-to-end tests for the Home Assistant, TeslaMate and Fleet API drivers.
  • GOFLAGS=-p=2 make verify: clean on 022db9f (tests, vet, build).

After the beta, on a site

A site that runs home_assistant_vehicle.lua as a local file keeps its local copy until someone removes it. To use the bundled driver: remove the local file, and add plugged and at_site to the Home Assistant automation, as the driver's header shows. The message it already sends keeps working.

🤖 Generated with Claude Code

…ged in

Move the device-drivers pin from 76ddd58 to 5cc7bb1a (srcfl/device-drivers#182)
and bundle home_assistant_vehicle, tesla_cloud, teslamate_vehicle and
vag_vehicle beside tesla_vehicle. Between the two pins only those five
drivers changed. fleetping's shipped list is regenerated from the pin.

The end-to-end vehicle test now runs the bundled copies, and the testdata
copies from #1660 go.

Supersedes #1449.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T09:28:46.337941Z 022db9f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@frahlg
frahlg merged commit f206613 into master Oct 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant