Repository navigation
fix(drivers): bundle the vehicle drivers that say where a car is plugged in - #1665
Merged
Merged
Conversation
…ged in Move the device-drivers pin from 76ddd58 to 5cc7bb1a (srcfl/device-drivers#182) and bundle home_assistant_vehicle, tesla_cloud, teslamate_vehicle and vag_vehicle beside tesla_vehicle. Between the two pins only those five drivers changed. fleetping's shipped list is regenerated from the pin. The end-to-end vehicle test now runs the bundled copies, and the testdata copies from #1660 go. Supersedes #1449. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the device-drivers pin from
76ddd58to5cc7bb1a(srcfl/device-drivers#182) and bundles the vehicle drivers, so the next beta ships them with the Core side that reads them (#1660).Supersedes #1449, the 26 September draft that proposed bundling
teslamate_vehicle,tesla_cloudandvag_vehicleat an older pin. It can be closed.What changes
drivers/BUNDLED_SOURCE.json: the pin, and four drivers added to the list:home_assistant_vehicle,tesla_cloud,teslamate_vehicleandvag_vehicle.tesla_vehiclewas already bundled.drivers/lua. No other bundled driver moves.go/internal/fleetping/shipped_gen.gois regenerated from the pin, as feat(drivers): bundle the TeslaMate, Tesla Fleet and VW Group vehicle drivers #1449 found it must be.testdatacopies it used go.minor: four drivers join the bundle.home_assistant_vehicleplugged, andplugged_sinceif the automation sends itat_sitefrom a tracker in zone hometesla_cloudplugged, no cable timesite_distance_mfromlocation_datateslamate_vehicleplugged, dated only with a livehealthyat_sitefrom the configured geofence, elsesite_distance_mvag_vehicleplugged, no cable timetesla_vehicleAll five send a level of 1 % or less as a fraction. None wakes a car; each does nothing until configured.
Note on the place.
host.site_location()answers only a driver whose signed catalog entry listsvehicle(#1660). A bundled copy runs without that signed entry, so a bundledtesla_cloudorteslamate_vehiclesends nosite_distance_m. TeslaMate's geofence and Home Assistant's zone still giveat_site. The same drivers installed from the signed channel get the distance. Extending the gate to bundled copies is a small Core change if wanted.Evidence
scripts/sync-bundled-drivers.shwrote 44 drivers from5cc7bb1a. All five vehicle drivers are byte-identical to device-driversmain.scripts/check-driver-versions.sh origin/master: "driver version changes verified across 44 bundled drivers".scripts/sync-bundled-drivers.sh --check: no driver source committed.go test -p 2 ./internal/drivers ./internal/fleetping: pass, includingTestBundledDriversMeetStartupContractand the end-to-end tests for the Home Assistant, TeslaMate and Fleet API drivers.GOFLAGS=-p=2 make verify: clean on 022db9f (tests, vet, build).After the beta, on a site
A site that runs
home_assistant_vehicle.luaas a local file keeps its local copy until someone removes it. To use the bundled driver: remove the local file, and addpluggedandat_siteto the Home Assistant automation, as the driver's header shows. The message it already sends keeps working.🤖 Generated with Claude Code