2026.1 kolla image build config#2453
Conversation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
etc/kayobe/kolla.yml (1)
210-218: 🩺 Stability & Availability | 🔴 Critical | ⚡ Quick winRemove the dangling repo URL references
stackhpc_repo_rhel_10_mariadb_10_11_urlis no longer defined; update this entry tostackhpc_repo_rhel_10_mariadb_11_4_url.stackhpc_repo_rhel_9_influxdb_urlis also gone, so this entry will fail templating until it is removed or restored.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@etc/kayobe/kolla.yml` around lines 210 - 218, Update the MariaDB repository entry to use stackhpc_repo_rhel_10_mariadb_11_4_url, and remove the InfluxDB repository entry referencing stackhpc_repo_rhel_9_influxdb_url. Preserve the remaining repository definitions unchanged.
🧹 Nitpick comments (1)
etc/kayobe/stackhpc.yml (1)
196-202: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueTrack the FIXME source pins before release.
stackhpc_kolla_source_version: 2026_1_backportsandstackhpc_kolla_ansible_source_version: stackhpc/2026.1are moving branch refs, so container builds are not reproducible until these revert to fixed tags. Fine for in-development 2026.1, but this should not ship as a stable release.Want me to open a tracking issue for reverting these to pinned tags?
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@etc/kayobe/stackhpc.yml` around lines 196 - 202, Before the stable 2026.1 release, replace the moving branch references in stackhpc_kolla_source_version and stackhpc_kolla_ansible_source_version with the appropriate fixed release tags, and update or remove the associated FIXME comments once pinned.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/stackhpc-build-kayobe-image.yml:
- Line 27: Update the base-image fallback used by the push workflow so it
resolves to rockylinux/rockylinux:10, matching the workflow’s default input.
Locate the push path’s inputs.base_image fallback and replace only the outdated
Rocky Linux 9 value.
---
Outside diff comments:
In `@etc/kayobe/kolla.yml`:
- Around line 210-218: Update the MariaDB repository entry to use
stackhpc_repo_rhel_10_mariadb_11_4_url, and remove the InfluxDB repository entry
referencing stackhpc_repo_rhel_9_influxdb_url. Preserve the remaining repository
definitions unchanged.
---
Nitpick comments:
In `@etc/kayobe/stackhpc.yml`:
- Around line 196-202: Before the stable 2026.1 release, replace the moving
branch references in stackhpc_kolla_source_version and
stackhpc_kolla_ansible_source_version with the appropriate fixed release tags,
and update or remove the associated FIXME comments once pinned.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b563bc2-0655-4999-b52f-8a58d0b06b73
📒 Files selected for processing (20)
.automation.github/workflows/ipa-image-build.yml.github/workflows/overcloud-host-image-build.yml.github/workflows/overcloud-host-image-promote.yml.github/workflows/overcloud-host-image-upload.yml.github/workflows/stackhpc-all-in-one.yml.github/workflows/stackhpc-build-kayobe-image.yml.github/workflows/stackhpc-container-image-build.ymletc/kayobe/apt.ymletc/kayobe/environments/ci-builder/stackhpc-ci.ymletc/kayobe/kolla-image-tags.ymletc/kayobe/kolla.ymletc/kayobe/kolla/kolla-build.confetc/kayobe/kolla/repos.yamletc/kayobe/pulp-repo-versions.ymletc/kayobe/pulp.ymletc/kayobe/stackhpc.ymletc/kayobe/trivy/allowed-vulnerabilities.ymltools/kolla-images.pytools/multiarch-manifests.sh
💤 Files with no reviewable changes (1)
- tools/kolla-images.py
Fixed 2 file(s) based on 3 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
60ac850 to
23ee4e5
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
etc/kayobe/kolla.yml (1)
210-239: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winFix the MariaDB repo variable name
stackhpc_repo_rhel_10_mariadb_10_11_urlshould bestackhpc_repo_rhel_10_mariadb_11_4_urlto matchetc/kayobe/stackhpc.ymlandetc/kayobe/kolla/repos.yaml. The RabbitMQ and ProxySQL entries look intentional.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@etc/kayobe/kolla.yml` around lines 210 - 239, Update the MariaDB repository entry in the repository list to use stackhpc_repo_rhel_10_mariadb_11_4_url instead of stackhpc_repo_rhel_10_mariadb_10_11_url. Leave the RabbitMQ and ProxySQL entries unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@etc/kayobe/kolla.yml`:
- Around line 134-137: Update the blazar-base git repository configuration to
use the stackhpc/2026.1 reference instead of stackhpc/master, while preserving
the existing repository location and type.
---
Outside diff comments:
In `@etc/kayobe/kolla.yml`:
- Around line 210-239: Update the MariaDB repository entry in the repository
list to use stackhpc_repo_rhel_10_mariadb_11_4_url instead of
stackhpc_repo_rhel_10_mariadb_10_11_url. Leave the RabbitMQ and ProxySQL entries
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ed6832a9-4c03-42cb-b1a6-f7e2afa1d659
📒 Files selected for processing (20)
.automation.github/workflows/ipa-image-build.yml.github/workflows/overcloud-host-image-build.yml.github/workflows/overcloud-host-image-promote.yml.github/workflows/overcloud-host-image-upload.yml.github/workflows/stackhpc-all-in-one.yml.github/workflows/stackhpc-build-kayobe-image.yml.github/workflows/stackhpc-container-image-build.ymletc/kayobe/apt.ymletc/kayobe/environments/ci-builder/stackhpc-ci.ymletc/kayobe/kolla-image-tags.ymletc/kayobe/kolla.ymletc/kayobe/kolla/kolla-build.confetc/kayobe/kolla/repos.yamletc/kayobe/pulp-repo-versions.ymletc/kayobe/pulp.ymletc/kayobe/stackhpc.ymletc/kayobe/trivy/allowed-vulnerabilities.ymltools/kolla-images.pytools/multiarch-manifests.sh
💤 Files with no reviewable changes (1)
- tools/kolla-images.py
🚧 Files skipped from review as they are similar to previous changes (17)
- .automation
- .github/workflows/overcloud-host-image-promote.yml
- etc/kayobe/kolla-image-tags.yml
- .github/workflows/overcloud-host-image-upload.yml
- etc/kayobe/apt.yml
- .github/workflows/ipa-image-build.yml
- .github/workflows/stackhpc-all-in-one.yml
- .github/workflows/stackhpc-container-image-build.yml
- .github/workflows/overcloud-host-image-build.yml
- .github/workflows/stackhpc-build-kayobe-image.yml
- etc/kayobe/kolla/repos.yaml
- etc/kayobe/kolla/kolla-build.conf
- etc/kayobe/pulp-repo-versions.yml
- etc/kayobe/environments/ci-builder/stackhpc-ci.yml
- etc/kayobe/trivy/allowed-vulnerabilities.yml
- etc/kayobe/pulp.yml
- etc/kayobe/stackhpc.yml
Kolla image build config for 2026.1 images, plus the first set of images.