Add fbc-inject-lifecycle task to FBC pipeline - #454
Conversation
78df1e3 to
7edbdeb
Compare
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Tekton pipeline now injects lifecycle data into the cloned source artifact. Image builds and FIPS checks consume the lifecycle-enriched artifact. ChangesLifecycle injection pipeline
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CloneRepository
participant FbcInjectLifecycle
participant BuildImages
participant FbcFipsCheckOciTa
CloneRepository->>FbcInjectLifecycle: cloned source artifact
FbcInjectLifecycle->>BuildImages: lifecycle-enriched SOURCE_ARTIFACT
FbcInjectLifecycle->>FbcFipsCheckOciTa: lifecycle-enriched SOURCE_ARTIFACT
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/operator-index-pipeline.yaml:
- Around line 239-240: Update the ociArtifactExpiresAfter parameter in the
fbc-inject-lifecycle step to use params.oci-artifact-expires-after instead of
params.image-expires-after, preserving the configured 1d default retention for
lifecycle artifacts.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 00e53244-6f4b-45e1-9583-fdcbae0962a3
📒 Files selected for processing (1)
.tekton/operator-index-pipeline.yaml
| - name: ociArtifactExpiresAfter | ||
| value: $(params.image-expires-after) |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
bundle='quay.io/konflux-ci/tekton-catalog/task-fbc-inject-lifecycle-oci-ta:0.1@sha256:da1217be1dcec3d5b5140ea351466607005481397b31f2b81108c4fd3012fbde'
tkn bundle list -o yaml "$bundle" task fbc-inject-lifecycle-oci-ta |
yq '{params: [.spec.params[].name], results: [.spec.results[].name]}'
rg -n -C 4 \
'ociArtifactExpiresAfter|image-expires-after|oci-artifact-expires-after' \
.tekton/operator-index-pipeline.yamlRepository: stackrox/operator-index
Length of output: 238
Use the OCI-artifact retention parameter for lifecycle artifacts.
fbc-inject-lifecycle receives ociArtifactExpiresAfter as a new OCI intermediate-artifact expiry. Pipeline parameter image-expires-after defaults to an empty value, while oci-artifact-expires-after defaults to 1d and is already used for clone-repository. Pass $(params.oci-artifact-expires-after) here so lifecycle artifacts get the configured retention deadline.
Proposed fix
- name: ociArtifactExpiresAfter
- value: $(params.image-expires-after)
+ value: $(params.oci-artifact-expires-after)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: ociArtifactExpiresAfter | |
| value: $(params.image-expires-after) | |
| - name: ociArtifactExpiresAfter | |
| value: $(params.oci-artifact-expires-after) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.tekton/operator-index-pipeline.yaml around lines 239 - 240, Update the
ociArtifactExpiresAfter parameter in the fbc-inject-lifecycle step to use
params.oci-artifact-expires-after instead of params.image-expires-after,
preserving the configured 1d default retention for lifecycle artifacts.
1 participant
Add
fbc-inject-lifecycle-oci-tato FBC pipelines