ROX-35007: enable modernize/newexpr

[janisz]

Description

Replace custom functions that returns a pointer to a value with new. Sometimes it requires a cast e.g. new(int32(1))
Refs:

• Refactor To function to use new for pointer creation kubernetes/utils#357

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• added unit tests
• added e2e tests
• added regression tests
• added compatibility tests
• modified existing tests

How I validated my change

CI

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[janisz]

This change is part of the following stack:

• ROX-35007: enable modernize/stditerators #21182
  • ROX-35007: enable modernize/strings #21183
    • ROX-35007: enable modernize/testingcontext,fmtappendf #21184
      • ROX-35007: enable modernize/slicessort,mapsloop #21185
        • ROX-35007: enable modernize/minmax,slicescontains #21186
          • ROX-35007: enable modernize/reflecttypefor #21187
            • ROX-35007: enable modernize/rangeint  #21188
              • ROX-35007: enable modernize/newexpr  #21189 ◀
                • ROX-35007: interface{} → any #21063

_{Change managed by git-spice.}

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • Replaced internal pointer-construction helpers with Go’s built-in pointer allocation across application, operator, sensor, CLI, and test code.
  • Removed the shared pointer utility package and updated related lint configuration.
  • Preserved existing runtime behavior, defaults, API contracts, and test expectations.

Walkthrough

The pull request replaces shared pointer helper calls with Go’s built-in new across production code, tests, operator defaults, resolvers, migration logic, sensor code, CLI tooling, and fixtures. It also removes the deleted helper package’s usages and updates the modernize linter configuration.

Changes

Pointer allocation migration

Layer / File(s)	Summary
Central services and transition definitions central/baseimage/..., central/complianceoperator/..., central/detection/..., central/sensor/...	Pointer helpers and local address-taking helpers are replaced with new, including transition state construction.
GraphQL resolver pointer construction central/graphql/resolvers/...	Resolver query, pagination, filter, sort, and status pointers now use direct allocations.
Operator defaults and translation tests operator/...	Operator defaults and test fixtures replace ptr.To and shared pointer helpers with new.
Package runtime and test utilities pkg/..., migrator/..., compliance/...	Runtime pointer construction, PostgreSQL metadata allocation, migration updates, and related tests are updated.
CLI, sensor, and integration test cleanup roxctl/..., sensor/..., tests/..., tools/...	CLI, sensor, Kubernetes fixture, integration-test, and tooling pointer creation is migrated to new.
Linter configuration .golangci.yml	The disabled modernize check changes from newexpr to any.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: grimmimeloni

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 21.57% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: enabling the modernize/newexpr check.
Description check	✅ Passed	The description explains the pointer-construction change, includes the required sections, and states that CI validated the change.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch modernize/newexpr

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🚀 Build Images Ready

Images are ready for commit af61b61. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-656-gaf61b61351

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@central/graphql/resolvers/image_vulnerabilities_benchmark_test.go`:
- Line 57: Update the Limit initialization in the benchmark test to use a typed
int32 value, such as a local int32 variable initialized to 20000 and passed by
address, or new(int32) with assignment; do not call new with the numeric
literal.

In `@central/graphql/resolvers/search_test.go`:
- Line 195: Update every test occurrence of Pagination.Limit using new(10) to
use new(int32(10)), ensuring the pointer type matches the field’s expected
*int32 type.

In `@tests/redhat_signing_key_test.go`:
- Around line 373-374: Update the DeploymentSpec.Replicas assignment in the test
to use an int32 value and pass its address, replacing new(1) with a
*int32-compatible expression.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dd1ea72d-d1b5-484c-9ce3-5763288f5903

📥 Commits

Reviewing files that changed from the base of the PR and between e76b3f3 and 759b6ec.

📒 Files selected for processing (66)

• .golangci.yml
• central/backgroundmigrations/runner/rollout_test.go
• central/baseimage/datastore/repository/datastore_impl_test.go
• central/baseimage/service/service_impl.go
• central/baseimage/service/service_impl_test.go
• central/complianceoperator/v2/integration/datastore/datastore_impl_test.go
• central/complianceoperator/v2/integration/service/convert_test.go
• central/complianceoperator/v2/integration/service/service_impl_test.go
• central/detection/alertmanager/alert_manager_impl_test.go
• central/graphql/resolvers/deployments_test.go
• central/graphql/resolvers/image_cve_core.go
• central/graphql/resolvers/image_cve_core_test.go
• central/graphql/resolvers/image_cve_v2_core_test.go
• central/graphql/resolvers/image_vulnerabilities_benchmark_test.go
• central/graphql/resolvers/image_vulnerabilities_v2_test.go
• central/graphql/resolvers/images_test.go
• central/graphql/resolvers/inputtypes/vuln_req_test.go
• central/graphql/resolvers/node_cve_core.go
• central/graphql/resolvers/node_cve_core_test.go
• central/graphql/resolvers/platform_cve_core_test.go
• central/graphql/resolvers/search_test.go
• central/graphql/resolvers/utils.go
• central/sensor/service/connection/upgradecontroller/stateutils/all_transitions.go
• central/views/imagecve/view_test.go
• central/views/imagecveflat/view_test.go
• compliance/collection/kubernetes/kubelet.go
• migrator/migrations/policymigrationhelper/policy_migrator.go
• migrator/migrations/policymigrationhelper/postgres_policy_migrator_test.go
• operator/api/v1alpha1/central_defaults_test.go
• operator/api/v1alpha1/common_types_test.go
• operator/internal/central/defaults/central_db.go
• operator/internal/central/defaults/central_db_test.go
• operator/internal/central/defaults/static.go
• operator/internal/central/extensions/reconcile_central_db_password_test.go
• operator/internal/central/extensions/reconcile_pvc_test.go
• operator/internal/central/values/translation/translation_test.go
• operator/internal/common/status/predicate_test.go
• operator/internal/securedcluster/defaults/admission_controller.go
• operator/internal/securedcluster/defaults/static.go
• operator/internal/securedcluster/extensions/reconcile_defaulting_test.go
• operator/internal/securedcluster/values/translation/translation_test.go
• operator/internal/tlsprofile/convert_test.go
• operator/internal/values/translation/translation_test.go
• pkg/booleanpolicy/evaluator/evaluator_test.go
• pkg/cluster/filtering.go
• pkg/cluster/filtering_test.go
• pkg/migratetooperator/central.go
• pkg/migratetooperator/securedcluster.go
• pkg/pointers/pointer.go
• pkg/protoconv/resources/resources_test.go
• pkg/search/postgres/common.go
• pkg/search/postgres/query_metadata.go
• roxctl/central/central.go
• roxctl/common/flags/endpoint_test.go
• roxctl/netpol/generate/generate_test.go
• roxctl/sensor/generate/openshift.go
• sensor/common/clusterentities/store_ips_test.go
• sensor/kubernetes/complianceoperator/utils.go
• sensor/kubernetes/fake/deployment.go
• sensor/kubernetes/fake/virtualmachines_test.go
• sensor/kubernetes/listener/resources/virtualmachine/store/virtual_machine_store_test.go
• tests/common.go
• tests/init_container_test.go
• tests/ocp_dynamic_plugin_test.go
• tests/redhat_signing_key_test.go
• tools/retest/github.go

💤 Files with no reviewable changes (2)

• pkg/pointers/pointer.go
• .golangci.yml

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.22%. Comparing base (07596ed) to head (af61b61).
⚠️ Report is 17 commits behind head on master.

Files with missing lines	Patch %	Lines
central/graphql/resolvers/utils.go	0.00%	8 Missing ⚠️
...igrations/policymigrationhelper/policy_migrator.go	0.00%	5 Missing ⚠️
...al/securedcluster/defaults/admission_controller.go	0.00%	3 Missing ⚠️
sensor/kubernetes/fake/deployment.go	0.00%	3 Missing ⚠️
central/graphql/resolvers/image_cve_core.go	0.00%	2 Missing ⚠️
pkg/migratetooperator/central.go	85.71%	1 Missing ⚠️
pkg/search/postgres/query_metadata.go	83.33%	1 Missing ⚠️
roxctl/sensor/generate/openshift.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21189      +/-   ##
==========================================
- Coverage   51.26%   51.22%   -0.05%     
==========================================
  Files        2869     2868       -1     
  Lines      179230   179222       -8     
==========================================
- Hits        91883    91800      -83     
- Misses      79289    79347      +58     
- Partials     8058     8075      +17     

Flag	Coverage Δ
go-unit-tests	51.22% <50.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vikin91]

Checked by machinery: "No correctness issues found in the scoped PR changes."

Manually checked the pkg & sensor folders - no issues.

[janisz]

/retest

[rhacs-bot]

/retest

[rhacs-bot]

/retest