[6.x] Fix stale Stache entry order when reordering structured collection#14896
Open
joshuablum wants to merge 2 commits into
Open
[6.x] Fix stale Stache entry order when reordering structured collection#14896joshuablum wants to merge 2 commits into
joshuablum wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in a structured collection with nested entries, reordering a parent entry from within the CP updates the tree correctly but on the frontend only the parent appears to move while its children keep their old positions until the Stache is manually cleared.
When a tree is saved
UpdateStructuredEntryOrderAndParentonly refreshed theorderindex for the IDs inCollectionTreeDiff::moved(). That excludes children of a moved parent so when a parent moved, its children's position shifted but their cachedorderwas never updated leaving them stale until you cleared the Stache.This refreshes the
orderindex and expands it to include each moved entry's tree descendants.Thanks to Ash for reporting it through support.