test: migrate math/base/special/rcbrt to ULP-based testing#12784
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.jsandtest/test.native.jsofmath/base/special/rcbrtfrom relative-tolerance (EPS-based) assertions to the ULP-based testing convention of [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.@stdlib/number/float64/base/ulp-difference) over all test fixtures. Every fixture block (8 positive blocks × 5003 cases, 6 negative blocks × 503 cases) has a maximum ULP difference of0: both the JavaScript and native (C) results are bit-identical to the Julia reference fixtures. Accordingly, per the migration convention, all migrated assertions use plaint.strictEqual( y, expected[ i ], 'returns expected value' );rather thanisAlmostSameValue, and the now-unusedEPSandabsrequires anddelta/tolvariables were removed.if/elseshort-circuit branches into the single exact assertion.Native results did not diverge from the JavaScript results (all native assertions pass with exact equality), so no native-specific larger tolerances (and no accompanying
NOTEcomments) were needed.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
Since all fixture values match exactly, this migration removes tolerance testing for this package entirely (exact equality) rather than introducing
isAlmostSameValue. Flagging for maintainer awareness in case looser tolerances are preferred for cross-platform native builds.Other
Minimum ULP values were independently re-verified by a second pass which recomputed the maximum ULP difference per fixture block; all blocks confirmed at
0. JavaScript tests pass via the official harness (make test), and the native add-on was built and all native test assertions pass locally.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated migration of
math/base/specialtest suites to ULP-based testing (issue #11352), including automated minimum-ULP discovery and an independent adversarial verification pass; the changes were reviewed before submission.@stdlib-js/reviewers