feat: add route and menu support for axes label properties#12899
Open
gururaj1512 wants to merge 5 commits into
Open
feat: add route and menu support for axes label properties#12899gururaj1512 wants to merge 5 commits into
gururaj1512 wants to merge 5 commits into
Conversation
kgryte
added
Feature
kgryte
reviewed
Jun 16, 2026
| event.property === 'width' || | ||
| event.property === 'height' || | ||
| event.source === 'padding' || | ||
| event.property === 'labelAlign' || |
Member
There was a problem hiding this comment.
If this lists keeps growing, we'll want to figure out a better way of handling these exceptions.
kgryte
reviewed
Jun 16, 2026
Member
There was a problem hiding this comment.
This folder is misspelled. s/seperation/separation/.
kgryte
reviewed
Jun 16, 2026
kgryte
reviewed
Jun 16, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jun 16, 2026
kgryte
reviewed
Jun 16, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jun 16, 2026
| 'units': 'px' | ||
| }, | ||
| 'labelAlign': { | ||
| 'description': '', |
Member
There was a problem hiding this comment.
These are all missing descriptions.
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Jun 16, 2026
kgryte
left a comment
kgryte
left a comment
Member
There was a problem hiding this comment.
Only a couple of minor comments remain to be resolved.
You'll likely want to regenerate the bundle again, as I made some edits to the app source files.
kgryte
added
the
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves None
Description
This pull request:
Related Issues
This pull request has the following related issues:
plot/vega/axis/label-overlaps#12898 to be mergedQuestions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
AI helped trace and troubleshoot the signal-less property rendering issue (labelBound input rendering and Vega signal errors), though the final changes were manually reviewed, built, and tested.
@stdlib-js/reviewers