Add opt-in Linux Quick View - #3973
stackingrockss wants to merge 2 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 25, 2026, 2:25 PM ET / 18:25 UTC (Revision 2). ClawSweeper reviewWhat this changesThe branch adds a compact Linux usage window opened by an explicit command or an off-by-default tray preference, restyles Settings, bundles provider icons, and adds Qt SVG to the Linux build. Merge readiness⛔ Blocked before merge - 3 items remain The owner’s requested opt-in direction is now reflected in the branch, and current main does not have this Quick View. One cost-display defect remains before merge. Priority: P3 Review scores
Verification
How this fits togetherThe Linux desktop reads usage and local spending from the CodexBar CLI, then displays them through Qt windows and a tray icon. Settings and command-line requests determine which window opens. flowchart LR
A[CLI usage and spending] --> B[Linux desktop controller]
C[Saved preferences] --> B
D[Command or tray click] --> E{Choose window}
B --> E
E --> F[Full usage window]
E --> G[Quick View]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Keep the opt-in window and show spending freshness, coverage, and failure state beside its cost totals, using the existing controller values. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: after a successful cost scan, make the next scan fail and reopen Quick View; source shows retained totals without the controller's stale-data warning. This path was established from source, not executed in this read-only review. Is this the best way to solve the issue? The opt-in route matches the owner's requested direction. The cost block still needs the same freshness and coverage context provided by the full dashboard. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against d8c2af958176. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
Thanks @stackingrockss. Code review confirms this changes ordinary launch, |
|
Thanks @stackingrockss for reworking this into the opt-in shape. I checked the new head |
Summary
Adds the compact Linux Quick View as an opt-in surface without changing the default window. Ordinary launch and
--usagestill open the full Usage & Spend window.--quick-viewopens the compact view explicitly; the tray's primary activation uses it only when the newcompactQuickViewpreference is enabled (off by default, shown as Use compact Quick View from the tray). The tray menu retains an explicit Quick View action.The compact view has Overview/provider tabs, the macOS provider icons, quota meters, reset/pace text, optional inline cost, and footer actions. Settings keeps the updated Linux layout. Provider fetching and authentication are unchanged. A cost scan starts on Quick View or Spending open, not on ordinary usage open. Inline provider cost is now labeled Cost across accounts. The Linux build action installs
qt6-svg-devfor the qmake SVG module.Refs #3971; this PR no longer depends on a decision to replace the default Linux window.
Pop!_OS screenshots
Captured with Qt 6.4.2 on Pop!_OS/COSMIC Wayland using the same synthetic Codex/Claude/Gemini usage and spending data. Before is the installed v0.61.0 UI; after is this PR. No personal account data appears.
--usage)Explicit Quick View after, plus refreshed Quick View and Settings captures in a dark theme.
Validation
--usage,--quick-view, and--settingsin the Wayland session with synthetic data; QML runtime logs showed no errors.qt6-svg-devis the Qt SVG development package installed on the Pop!_OS test host and supplying the qmake SVG module.make testandmake checkwere attempted in the agent container, wheremakeis unavailable; the Pop!_OS host has make but not Swift/SwiftFormat/SwiftLint. The repository's macOS gates remain for CI.