Repository navigation
Match raw capture capabilities to the selected camera - #60
Draft
steveseguin wants to merge 1 commit into
Draft
steveseguin wants to merge 1 commit into
steveseguin wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
--raw --v4l2 /dev/v4l/by-id/...(orby-path), capability discovery compares the persistent path literally to the device monitor's/dev/videoNpath. It fails to identify the selected camera and borrows the first camera's capabilities instead. With multiple cameras advertising different raw formats, the resulting pipeline can constrain the selected camera to an unsupported format and prevent capture startup.Change
Verification
gi; Compatibility CI passed at final headd4270b8bcb9b91f193c0ecc3c23a8679e96a27ec: all 155 tests pass on each of Bullseye/Python 3.9/GStreamer 1.18, Bookworm/3.11/1.22, and Trixie/3.13/1.26, including all five new identity tests. This does not establish physical-camera interoperability.Reviewed against main
4f94ca2dcfced9f67eb72acf4102518cd3ef6674. No physical camera, remote board, external signaling, merge or deployment was used. This verifies identity selection and caps compatibility, not hardware/end-to-end media. Libcamera selection is unchanged. Independent of drafts #57, #58 and #59.